This repository has been archived by the owner on Mar 31, 2022. It is now read-only.
travis: test on jdk9 and jdk10, fix issues #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis doesn't seem to have `openjdk9`, so using `oraclejdk9`.
vbhavsar
reviewed
Oct 5, 2018
| } | ||
|
|
||
| private GenericContainer createFrontend(final Network network, | ||
| final GenericContainer backendJob) { |
There was a problem hiding this comment.
thanks, that was left over from an earlier version of the code - updated
helios-testing is not yet Java 9 compatiable
mattnworb
force-pushed
the
test-on-java9
branch
from
1d17cbe to
0f5688e
Compare
|
I believe this addresses #77 and makes the plugin compatible on Java 9/10. I've tested this by installing the plugin locally ( @spotify/docker-admins |
vbhavsar
reviewed
Oct 5, 2018
|
|
||
| return new GenericContainer(image) | ||
| .withExposedPorts(1338) | ||
| .withCommand("http://backend:" + BACKEND_PORT) |
There was a problem hiding this comment.
What is the point of this command? It is just a uri.
There was a problem hiding this comment.
the frontend container expects it as an argument to know how to talk to the backend container:
mattnworb
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis doesn't seem to have
openjdk9, so usingoraclejdk9.