Change distribution value type to ByteString #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malish8632
approved these changes
Sep 15, 2020
sming
approved these changes
Sep 15, 2020
spkrka
reviewed
Sep 16, 2020
| ByteBuffer out = ByteBuffer.allocate(bytes.length); | ||
| out.put(bytes); | ||
| return out; | ||
| return ByteString.copyFrom(out.array()); |
There was a problem hiding this comment.
Seems unnecessary to go from byte[] -> ByteBuffer -> ByteString
Simplify to ByteString.copyFromUtf8(...)?
spkrka
reviewed
Sep 16, 2020
| @@ -94,7 +94,8 @@ public void testSerializeDistributionValue() throws InvalidProtocolBufferExcepti | |||
| final byte [] pointVal = DISTRIBUTION_DATA_POINT.getBytes(StandardCharsets.UTF_8); | |||
| ByteBuffer byteBuffer = ByteBuffer.allocate(pointVal.length); | |||
| byteBuffer.put(pointVal); | |||
| Metric metricV1 = (new Metric()).value(Value.distributionValue(byteBuffer)); | |||
| Metric metricV1 = (new Metric()).value(Value | |||
| .distributionValue(ByteString.copyFrom(byteBuffer.array()))); | |||
There was a problem hiding this comment.
Nit: ByteString.copyFrom(byteBuffer) might be cleaner, but perhaps you would then first need to flip the buffer
There was a problem hiding this comment.
Actually - just do ByteString.copyFromUtf8(DISTRIBUTION_DATA_POINT) instead
spkrka
reviewed
Sep 16, 2020
| @@ -40,14 +40,14 @@ public static Value doubleValue(double value) { | |||
| return DoubleValue.create(value); | |||
| } | |||
|
|
|||
| public static Value distributionValue(ByteBuffer byteBuffer) { | |||
| return DistributionValue.create(byteBuffer); | |||
| public static Value distributionValue(ByteString byteString) { | |||
There was a problem hiding this comment.
This would be a breaking change, which I think we can live with if we are sure no one is depending on this.
Otherwise, we would need to keep the old method signature too
There was a problem hiding this comment.
No one is using it. Nothing will break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.