fix a few compiler/Maven warnings (#231)

* modules/protobuf: remove duplicate dependencies in pom.xml * SemanticCoreStatistics: fix two compiler warnings redundant cast to `long`, use of raw `Gauge` type
spotify · Jan 20, 2021 · 5a3f7f5 · 5a3f7f5
1 parent e425e90
commit 5a3f7f5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 25 deletions.
diff --git a/agent/src/main/java/com/spotify/ffwd/statistics/SemanticCoreStatistics.java b/agent/src/main/java/com/spotify/ffwd/statistics/SemanticCoreStatistics.java
@@ -54,7 +54,7 @@ public Histogram newMetric() {
 
             @Override
             public boolean isInstance(final Metric metric) {
-                return Histogram.class.isInstance(metric);
+                return metric instanceof Histogram;
             }
         };
 
@@ -99,9 +99,9 @@ public OutputManagerStatistics newOutputManager() {
             private final Counter metricsDroppedByCardinalityLimit =
               registry.counter(m.tagged("what", "metrics-dropped-by-cardlimit", "unit", "metric"));
 
-            private final Gauge metricsCardinalityMetric =
+            private final Gauge<Long> metricsCardinalityMetric =
               registry.register(m.tagged("what", "metrics-cardinality"),
-                  (Gauge<Long>) () -> (long) metricsCardinality.get());
+                  (Gauge<Long>) metricsCardinality::get);
 
             @Override
             public void reportSentMetrics(int sent) {

diff --git a/modules/protobuf/pom.xml b/modules/protobuf/pom.xml
@@ -25,33 +25,22 @@
       <artifactId>ffwd-api</artifactId>
     </dependency>
 
-    <dependency>
-      <groupId>junit</groupId>
-      <artifactId>junit</artifactId>
-    </dependency>
-
     <dependency>
       <groupId>com.spotify.ffwd</groupId>
       <artifactId>ffwd-client</artifactId>
       <version>0.2.4</version>
     </dependency>
 
-  <!-- testing -->
-  <dependency>
-    <groupId>junit</groupId>
-    <artifactId>junit</artifactId>
-    <scope>test</scope>
-  </dependency>
-  <dependency>
-    <groupId>org.mockito</groupId>
-    <artifactId>mockito-core</artifactId>
-    <scope>test</scope>
-  </dependency>
-  <dependency>
-    <groupId>org.mockito</groupId>
-    <artifactId>mockito-core</artifactId>
-    <scope>test</scope>
-  </dependency>
-
+    <!-- testing -->
+    <dependency>
+      <groupId>junit</groupId>
+      <artifactId>junit</artifactId>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.mockito</groupId>
+      <artifactId>mockito-core</artifactId>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
 </project>