This repository has been archived by the owner on Mar 15, 2021. It is now read-only.
Add new output plugin for sending OpenTelemetry metrics over gRPC. #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ao2017
reviewed
Jan 21, 2021
| } | ||
|
|
||
| @Override | ||
| public void sendBatch(Batch batch) { |
There was a problem hiding this comment.
I wonder why batch is not supported ?
There was a problem hiding this comment.
Its just not necessary right now, and the best way to map a batch to the OT metric definition isn't 100% clear so I'm kicking the can for the moment.
ao2017
reviewed
Jan 21, 2021
| metricBuilder.setUnit(unit); | ||
| } | ||
|
|
||
| ExportMetricsServiceRequest request = ExportMetricsServiceRequest.newBuilder() |
There was a problem hiding this comment.
How is this metric used upstream ?
There was a problem hiding this comment.
Depends on the receiver. For Lightstep, the metrics are grouped on the name and then allow tag filtering/grouping under that.
ao2017
reviewed
Jan 21, 2021
modules/opentelemetry/src/main/java/com/spotify/ffwd/opentelemetry/OpenTelemetryPluginSink.java
Show resolved
Hide resolved
ao2017
reviewed
Jan 21, 2021
modules/opentelemetry/src/main/java/com/spotify/ffwd/opentelemetry/OpenTelemetryPluginSink.java
Show resolved
Hide resolved
hexedpackets
force-pushed
the
opentelemetry
branch
from
aa169e4 to
a851818
Compare
ao2017
approved these changes
Jan 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently batches and distibutions are not supported. I plan to add them in later if this turns out to be useful.
Closes #228