Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for getting a PR's patch. #139

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Conversation

olbapmar
Copy link
Contributor

This also adds a new request method that accepts extra headers and doesn't try to parse JSON

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #139 (c539a95) into master (18e478c) will increase coverage by 0.15%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master     #139      +/-   ##
============================================
+ Coverage     74.94%   75.10%   +0.15%     
- Complexity      272      275       +3     
============================================
  Files            42       42              
  Lines           946      960      +14     
  Branches         41       42       +1     
============================================
+ Hits            709      721      +12     
- Misses          212      213       +1     
- Partials         25       26       +1     
Impacted Files Coverage Δ
...m/spotify/github/v3/clients/PullRequestClient.java 43.10% <77.77%> (+6.36%) ⬆️
...va/com/spotify/github/v3/clients/GitHubClient.java 76.98% <100.00%> (+0.46%) ⬆️

This also adds a new request method that accepts extra headers and doesn't try to parse JSON
Copy link
Contributor

@ebk45 ebk45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olbapmar thank you so much for contributing to our open source client! We'll get these changes merged and released for you now :)

@ebk45 ebk45 merged commit 32ac475 into spotify:master Jul 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants