bug: Check run id can be bigger than MAX_INT #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if it can be bigger than long either, but this does not make things worse and solves the issue I ran into.
…consistency Every other file in the same folder uses dashes, lets go with them.
vootelerotov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Ran into an issue where the response I got when using
ChecksClient::getCheckRunscould not be deserialized, due to the id being too big to fit intoInteger.The Github API definition does not specify the number of bits the ID is, see here. I am guessing that under
integerthey have wider definition in mind than Java 32-bitInteger.Solution
Integer->Long.Notes
Also did some clean-up, to have consistency in file names in the test file folder.