Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create separate team update request #145

Merged
merged 3 commits into from
Aug 31, 2023
Merged

feat: create separate team update request #145

merged 3 commits into from
Aug 31, 2023

Conversation

ebk45
Copy link
Contributor

@ebk45 ebk45 commented Aug 31, 2023

What does this PR do?

  • Fixes the PATCH teams endpoint so that it has a separate Team Update request with the correct fields that can be modified.
  • Updates the maintainers and repo_names attributes in the Team Create request from Strings to Array of Strings.
  • Adds missing privacy and notification_setting attributes to the Team Create request.

How to test?

Unit tests

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #145 (be02e2c) into master (02dadcf) will increase coverage by 0.02%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #145      +/-   ##
============================================
+ Coverage     75.61%   75.64%   +0.02%     
  Complexity      279      279              
============================================
  Files            42       42              
  Lines           968      969       +1     
  Branches         42       42              
============================================
+ Hits            732      733       +1     
  Misses          211      211              
  Partials         25       25              
Files Changed Coverage Δ
...java/com/spotify/github/v3/clients/TeamClient.java 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@ebk45 ebk45 self-assigned this Aug 31, 2023
@ebk45 ebk45 merged commit a68a9f2 into master Aug 31, 2023
3 checks passed
@ebk45 ebk45 deleted the fix-patch-teams branch August 31, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants