-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for creating and updating file contents #148
feat: add support for creating and updating file contents #148
Conversation
@GithubStyle | ||
@JsonSerialize(as = ImmutableFileCreate.class) | ||
@JsonDeserialize(as = ImmutableFileCreate.class) | ||
public interface FileCreate { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went with request object, not sure where do you draw the line for sensible amount of parameters. Was on the fence with 3 here, with 4 for FileUpdate
it seemed more clear cut.
import org.powermock.core.classloader.annotations.PrepareForTest; | ||
import org.powermock.modules.junit4.PowerMockRunner; | ||
import uk.co.datumedge.hamcrest.json.SameJSONAs; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw it on classpath, okay to use? Do not want to worry about difference in whitespace/order in mock and real-deal.
Bumping this up, anything I can do from my side to get this merged in? |
@dziemba, could you please tell me if there is anything else I could do to get this PR rolling? Not fond of pulling in one specific person, but starting to think that this PR might have fell through the cracks :) |
Hi @vootelerotov. We apologise for taking so long to get eyes on this PR, we haven't been able to maintain this library to the standard we would have liked to but this will be changing in the new year. If you could please get this rebased and we'll be prioritising all open PRs ready for review. Thanks! Ellie |
17cc521
to
c0e19bf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #148 +/- ##
============================================
+ Coverage 76.86% 77.00% +0.13%
- Complexity 297 299 +2
============================================
Files 42 42
Lines 1003 1009 +6
Branches 44 44
============================================
+ Hits 771 777 +6
Misses 207 207
Partials 25 25 ☔ View full report in Codecov by Sentry. |
Do not be too demanding with yourself, it takes a lot of work to maintain an OSS library, especially supporting features that you are not using yourself. I have used this wrapper in multiple small projects, and I have found it useful as-is.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
See https://docs.github.com/en/rest/repos/contents?apiVersion=2022-11-28#create-or-update-file-contents.
I applied the well known engineering principle of "monkey-see-monkey-do". Hopefully my grasp of how to do things in this project is not off too much. Checkstyle yelling at me was definitely helpful.
Happy to do smaller follow-ups :)