Move stuff to contrib #1997
Merged
Move stuff to contrib #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlstadther
approved these changes
Jan 24, 2017
|
@dlstadther, well, they'll only get an deprecation warning in the beginning. The temporary backward compatibility modules will eventually be deleted tough. So they have time to upgrade between versions. |
While it's of course a bit subjective that what is core and not. I settled on choosing these modules. I found the rest either to be kind of core or very hard to move and eventually create seperate packages for. I conciously did not create an `luigi/mrrunner.py` importing contrib, as it will not do as one expects as you typically will use `.__file__` on it to ship it with your map reduce job.
And also guide away new users from using this pretty old technology.
Tarrasch
force-pushed
the
move_stuff_to_contrib
branch
from
d09ff96 to
1bef1d0
Compare
Tarrasch
added a commit
to Tarrasch/luigi
that referenced
this pull request
Jul 12, 2017
After this commit the following imports will no longer work
import luigi.file
import luigi.s3
import luigi.postgres
Instead use
import luigi.contrib.{file,s3,postgres}
This is a continution on spotify#1997
Tarrasch
added a commit
to Tarrasch/luigi
that referenced
this pull request
Jul 12, 2017
After this commit the following imports will no longer work
import luigi.s3
import luigi.postgres
Instead use
import luigi.contrib.{s3,postgres}
This is a continution on spotify#1997
Tarrasch
added a commit
that referenced
this pull request
Aug 25, 2017
After this commit the following imports will no longer work
import luigi.s3
import luigi.postgres
Instead use
import luigi.contrib.{s3,postgres}
This is a continution on #1997
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While it's of course a bit subjective that what is core and not. I
settled on choosing these modules. I found the rest either to be kind
of core or very hard to move and eventually create seperate packages
for.
I conciously did not create an
luigi/mrrunner.pyimporting contrib, asit will not do as one expects as you typically will use
.__file__onit to ship it with your map reduce job.
Motivation and Context
This is a step in the direction of defining something that is later core. Eventually
luigi.contribcan be split into modules.Have you tested this? If so, how?
Nope. I tried to edit the files carefully, and then there will be Travis testing this out.