Handle e-mail failures in batch notifier #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As there's not much we can do about not sending e-mails, we just ignore the error. In order to prevent constant e-mail processing, we also clear all the e-mails from the queue and reset the time period for the next send.
daveFNbuck
force-pushed
the
handle_batch_exception
branch
from
3ee4b3e to
2b7a477
Compare
Tarrasch
approved these changes
Jul 11, 2017
dlstadther
approved these changes
Jul 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ignore e-mail send failures, and ensure we still clean up as if the e-mails were send.
Motivation and Context
#1957, failed e-mail sends can stall the scheduler. As there's not much we can do about not sending e-mails, we just ignore the error. In order to prevent constant e-mail processing, we also clear all the e-mails from the queue and reset the time period for the next send.
Have you tested this? If so, how?
Unit tests, plus I've been using this in production for about 6 months.