Fix emailing of unexpected error in Worker._announce_scheduling_failure.
#2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tarrasch
approved these changes
Jul 29, 2017
There was a problem hiding this comment.
Fine to merge but:
This code branch is not tested (as I see in coverage info), so it should not affect any builds. But I can include a test case for this if needed.
It would of course be nice if you even improved coverage. Especially as a new code path is introduced now.
|
Done! :) |
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a small issue with error reporting.
Motivation and Context
The code after
raiseis unreachable and_email_unexpected_errorwill never be executed in this case. It seems like a typo.Have you tested this? If so, how?
This code branch is not tested (as I see in coverage info), so it should not affect any builds. But I can include a test case for this if needed.
Kind Regards