Kubernetes: Don't set activeDeadlineSeconds by default #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlstadther
approved these changes
Jul 9, 2018
yonromai
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't set the activeDeadlineSeconds key in kubernetes job spec by default.
Motivation and Context
I assume tasks take longer to finish then 100 seconds (the current default). I also assume you usually don't know how long the task will take. So not setting this as a default seems reasonable to me. See also #2383
Have you tested this? If so, how?
Still need to run tests. I have a pipeline which uses this job but in the current release it is broken. I'll try to use this version for next run.