Multiple requires #2475
Merged
Multiple requires #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not familiar with these features. I'll try to look into them and provide you a review afterward. Thanks for the submission! |
dlstadther
approved these changes
Jul 29, 2018
There was a problem hiding this comment.
As i previously mentioned, I don't have experience with these util decorators. However, after looking into this code (assume the old code functioned correctly), your additions to handle arbitrary number of inheritances and requires makes sense to me.
I'm good with this after one other positive review!
luigi/util.py
Outdated
| if len(self.tasks_to_require) == 1: | ||
| return _self.clone_parent() | ||
|
|
||
| return _self.clone_parents() |
There was a problem hiding this comment.
Possibly make this a one-liner (equally clear, but prettier)
return _self.clone_parent() if len(self.tasks_to_require) == 1 else _self.clone_parents()
StasDeep
force-pushed
the
feature/multiple-requires
branch
from
3829fec to
e20e82e
Compare
Tarrasch
approved these changes
Jul 30, 2018
| class MySecondTask(luigi.Task): | ||
| def requires(self): | ||
| return self.clone_parents() | ||
|
|
There was a problem hiding this comment.
Can you add a 'note' that this was added after version 2.7.6?
test/decorator_test.py
Outdated
| class shouldfail(luigi.Task): | ||
| pass | ||
|
|
||
| self.assertRaises(TypeError, create_task_with_empty_inheritance) |
There was a problem hiding this comment.
Can you replace this with the with decorator for assertRaises?
test/decorator_test.py
Outdated
| class shouldfail(luigi.Task): | ||
| pass | ||
|
|
||
| self.assertRaises(TypeError, create_task_with_empty_requires) |
|
Huge thanks for updating the documentation as well! |
|
Interestingly, I just came across an attempt at this same intention almost 2 years ago in #1845 |
StasDeep
force-pushed
the
feature/multiple-requires
branch
from
e20e82e to
3829fec
Compare
|
@Tarrasch could you please explain how I should test it in production? |
|
I believe he just means use your own code for your own pipelines and verify it functions the way you expect. |
|
@Tarrasch @dlstadther I believe this is ready to be merged. |
|
Did production tests of this code function as expected in your "live" pipelines @StasDeep ? |
|
@dlstadther yes, everything works as expected. |
thisiscab
pushed a commit
to glossier/luigi
that referenced
this pull request
Aug 8, 2018
Add support for multiple task arguments for requires and inherits decorators
dlstadther
added a commit
to dlstadther/luigi
that referenced
this pull request
Aug 14, 2018
* upstream-master: (82 commits) S3 client refactor (spotify#2482) Rename to rpc_log_retries, and make it apply to all the logging involved Factor log_exceptions into a configuration parameter Fix attribute forwarding for tasks with dynamic dependencies (spotify#2478) Add a visiblity level for luigi.Parameters (spotify#2278) Add support for multiple requires and inherits arguments (spotify#2475) Add metadata columns to the RDBMS contrib (spotify#2440) Fix race condition in luigi.lock.acquire_for (spotify#2357) (spotify#2477) tests: Use RunOnceTask where possible (spotify#2476) Optional TOML configs support (spotify#2457) Added default port behaviour for Redshift (spotify#2474) Add codeowners file with default and specific example (spotify#2465) Add Data Revenue to the `blogged` list (spotify#2472) Fix Scheduler.add_task to overwrite accepts_messages attribute. (spotify#2469) Use task_id comparison in Task.__eq__. (spotify#2462) Add stale config Move github templates to .github dir Fix transfer config import (spotify#2458) Additions to provide support for the Load Sharing Facility (LSF) job scheduler (spotify#2373) Version 2.7.6 ...
dlstadther
added a commit
to dlstadther/luigi
that referenced
this pull request
Aug 14, 2018
* upstream-master: S3 client refactor (spotify#2482) Rename to rpc_log_retries, and make it apply to all the logging involved Factor log_exceptions into a configuration parameter Fix attribute forwarding for tasks with dynamic dependencies (spotify#2478) Add a visiblity level for luigi.Parameters (spotify#2278) Add support for multiple requires and inherits arguments (spotify#2475) Add metadata columns to the RDBMS contrib (spotify#2440) Fix race condition in luigi.lock.acquire_for (spotify#2357) (spotify#2477) tests: Use RunOnceTask where possible (spotify#2476) Optional TOML configs support (spotify#2457) Added default port behaviour for Redshift (spotify#2474) Add codeowners file with default and specific example (spotify#2465) Add Data Revenue to the `blogged` list (spotify#2472)
dlstadther
added a commit
to dlstadther/luigi
that referenced
this pull request
Aug 16, 2018
* upstream-master: Remove long-deprecated scheduler config variable alternatives (spotify#2491) Bump tornado milestone version (spotify#2490) Update moto to 1.x milestone version (spotify#2471) Use passed password when create a redis connection (spotify#2489) S3 client refactor (spotify#2482) Rename to rpc_log_retries, and make it apply to all the logging involved Factor log_exceptions into a configuration parameter Fix attribute forwarding for tasks with dynamic dependencies (spotify#2478) Add a visiblity level for luigi.Parameters (spotify#2278) Add support for multiple requires and inherits arguments (spotify#2475) Add metadata columns to the RDBMS contrib (spotify#2440) Fix race condition in luigi.lock.acquire_for (spotify#2357) (spotify#2477) tests: Use RunOnceTask where possible (spotify#2476) Optional TOML configs support (spotify#2457) Added default port behaviour for Redshift (spotify#2474) Add codeowners file with default and specific example (spotify#2465) Add Data Revenue to the `blogged` list (spotify#2472) Fix Scheduler.add_task to overwrite accepts_messages attribute. (spotify#2469) Use task_id comparison in Task.__eq__. (spotify#2462)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now
requiresdecorator can take multiple tasks to require, as well asinheritsdecorator (no need to stack them now). Butclone_parentmethod becomes ambiguous in cases when there are 2+ tasks to inherit. I've kept it as is to not break anything and addedclone_parentsmethod, that is used insiderequiresdecorator.Motivation and Context
Resolves #1934.
Have you tested this? If so, how?
I have included new unit tests.