Fix error #2507 #2509
Fix error #2507 #2509
Conversation
| @@ -822,7 +822,7 @@ def add_task(self, task_id=None, status=PENDING, runnable=True, | |||
| task.family = family | |||
| if not getattr(task, 'module', None): | |||
| task.module = module | |||
| if not task.param_visibilities: | |||
| if not getattr(task, 'param_visibilities', None): | |||
There was a problem hiding this comment.
hasattr(task, 'param_visibilities') is more concise with the same effect, but either one works.
There was a problem hiding this comment.
There is a chance that task will have param_visibilities equal to {} by default and in this case hasattr may return True, but expected result was False.
So, just to avoid additional check i've decided to use getattr
There was a problem hiding this comment.
Good point. Stick with getattr. Thanks!
|
Approved, though you will have to figure out why the Travis build is failing and take appropriate action. |
|
There is a lot of failed S3 tests. I'm not sure that this change has broken it, but i'll re-check it anyway |
|
No specific luigi PR appears to be the cause of the s3 test failures. I suspect it has to do with a dependency update. I've take a couple minutes and found that boto3 and botocore versions increased between passing and failing builds. But don't have more time to dedicate. Any and all efforts provided to identify and resolve this issue will be most appreciated! |
|
👏 👏 👏 |
Description
Replace direct attribute accessing by using built-n function
getattrMotivation and Context
Fixes #2507
Have you tested this? If so, how?
I tried to reproduce this issue without and with this patch. As local test showed, this patch fix this issue