Fix ReadTheDocs build #2546
Merged
Fix ReadTheDocs build #2546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic! Thanks for submitting @jethron ! Mind resolving the flake8 issue? |
|
Done @dlstadther, but not sure how best to resolve the codecov check for such a small commit? |
|
Thanks! Just ignore that top codecov check - it doesn't seem to be consistent |
dlstadther
approved these changes
Oct 5, 2018
|
RTD build passed and contrib docs are back! Thanks so much @jethron ! |
|
Thanks @jethron! |
dlstadther
added a commit
to dlstadther/luigi
that referenced
this pull request
Nov 19, 2018
* upstream-master: Make Worker parameter task_process_context an OptionalParameter (spotify#2468) (spotify#2574) Version 2.8.0 Implement configurable CORS. Add HdfsFlagTarget (spotify#2559) Fix HdfsAtomicWriteDirPipe.close() when using snakebite and the file do not exist. (spotify#2549) Small fix to logging in contrib/ecs.py (spotify#2556) [ImgBot] optimizes images (spotify#2555) Add CopyToTable task for MySQL (spotify#2553) Make capture_output non-positional in ExternalProgramTask (spotify#2547) Add Movio to list of Luigi users (spotify#2551) Interpolate environment variables in .cfg config files (spotify#2527) Fix ReadTheDocs build (spotify#2546)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix RTD builds that have been broken since 7b06c90 and should also fix #2464
Motivation and Context
RTD builds fail since 7b06c902a2 since RTD tries to remove
python-daemon<3.0from install_requries but it has been changed topython-daemon<2.2.0Prior to that, AWS modules in contrib were not generating documentation due to ImportErrors on botocore & boto3 as documented in #2464
This guards the imports so they don't raise the exception in line with the other modules in
contribthat have 3rd party dependencies.Also cleans up the dependency on enum34 for older python versions;
install_requiressupports version checks automatically without checkingsys.version_info.Have you tested this? If so, how?
I ran my jobs with this code and it works for me.
I build the documentation via the process described on RTD in a Py2 venv and generated complete documentation.