Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast datetime to str before setting 'date' key in RedisTarget #2722

Merged
merged 1 commit into from
Jun 7, 2019

Conversation

KenyaDonDraper
Copy link
Contributor

Fixes #2721

@dlstadther
Copy link
Collaborator

@Gr1f0n6x , given you added Redis support, could you confirm this shouldn't negatively impact existing uses of this module?

@nryanov
Copy link
Contributor

nryanov commented Jun 4, 2019

@dlstadther , unfortunately, I'm not an author of this module. The real author is @pbamba (#2489).
But, as I think, this change should not has negative impact. For existing code it will be equal to double call to str. It may add some overhead (probably, too small for worrying).

@dlstadther dlstadther merged commit e385a00 into spotify:master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RedisTarget is incompatible with redis-py >= 3
3 participants