Fix python 3.8 and 3.9 apache CI in dirty way #3113
Conversation
hirosassa
requested review from
dlstadther,
Tarrasch and
a team
as code owners
hirosassa
force-pushed
the
fix-py38-py39-version-CI
branch
from
5234bab to
9b3d1c7
Compare
hirosassa
force-pushed
the
fix-py38-py39-version-CI
branch
from
9b3d1c7 to
5889c85
Compare
hirosassa
changed the title
There was a problem hiding this comment.
I've really fallen behind on reviews. I see that you've been keeping this branch up-to-date. I'm good with your solutions here for the sake of stable test builds. The path manipulation isn't ideal, but it allows better coverage against github actions' python versions 3.8 and 3.9. So i'll approve and merge.
Thanks for your patience and sorry again for my massive delays.
|
@dlstadther Thank you very much for the review! |
|
Not sure what's up with the 2 tests that CI is waiting on. When i click into the Actions tab, i don't see those tests in the execution for this branch. |
|
@dlstadther I disabled tests running on 3.8.9 and 3.9.4, and enabled 3.8 and 3.9 tests. So we need to change GitHub Actions configuration after this PR is merged. |
|
Hmmm... Problem is that Github won't let me merge this PR until all tests return successful :/, including the two which are being replaced. Ideas? |
|
@dlstadther |
|
Unfortunately, I don't have access to the repo's settings. I've only ever been a community member maintainer, never an admin or Spotify employee. So we may need one of the "dataex" members to help us out. @honnix @sonjaer @ckiosidis @jesperps |
|
I looked at this a bit more and experimented, but came to the same conclusion as you @hirosassa . Without ability to modify those branch protection rules, we can't merge this :( |
|
@narape How about you Nelson? |
|
Sorry I missed the ping. I just updated the settings. |
|
@honnix Thank you very much! |
|
Thank you @honnix ! @hirosassa , feel free to update your branch with master and i'll merge once i see all greens! (no rush) |
|
@dlstadther Updated! Thank you for your help! |
Description
Related to #3091
I fixed Python 3.8 and 3.9 apache CI.
By importlib change in Python 3.9.5 release,
__import__()returns absolute path of each modules or packages (this is relative path in previous version).To maintain backward compatibility, I implemented dirty solutions (just rewrite absolute path into relative one).
I'd like to discuss my changes like this and find good solutions.
Motivation and Context
To follow Python latest versions.
Have you tested this? If so, how?
I ran test locally and GitHub Actions.