Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OptionalParameter in ExternalPythonProgramTask #3130

Merged
merged 1 commit into from
Dec 28, 2021
Merged

OptionalParameter in ExternalPythonProgramTask #3130

merged 1 commit into from
Dec 28, 2021

Conversation

oinegue
Copy link
Contributor

@oinegue oinegue commented Dec 9, 2021

As of now, ExternalPythonProgramTask parameters are simple Parameter.
But the default for both of them is None and they are used only if they are not None.
If the value for any of them is not provided, a warning is raised, for example:
UserWarning: Parameter "extra_pythonpath" with value "None" is not of type string.

Therefore I think that the appropriate type is OptionalParameter instead.

PS: First pull request for me, I hope I'm doing it right. Otherwise please help me understand what's wrong. Thanks

Updated ExternalPythonProgramTask parameters type to OptionalParameter
@oinegue oinegue requested review from dlstadther and a team as code owners December 9, 2021 17:36
Copy link
Collaborator

@dlstadther dlstadther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dlstadther dlstadther merged commit 4896c88 into spotify:master Dec 28, 2021
@oinegue oinegue deleted the patch-1 branch December 30, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants