Close requests.Socket in RemoteScheduler before exiting (#3173) #3175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If using
luigi.build
andsys.exit
,ResourceWarning
on unclosed socket is raised. As it can be easily fixed, I've addedrequests.Session.close
call before exiting.Motivation and Context
Fixes #3173
Have you tested this? If so, how?
I've tested it using code below under py38. Adding solid unit/integration test requires running remote scheduler and I will need guidance if one is needed.