-
Notifications
You must be signed in to change notification settings - Fork 0
add the publishing to gpr and release pipeline #25
Conversation
c671289
to
97f7fb7
Compare
register<MavenPublication>("release") { | ||
groupId = "dev.openfeature" | ||
artifactId = "kotlin-sdk" | ||
version = "0.0.1-SNAPSHOT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct? shouldn't we pull this from somewhere? The tag info for example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, we should think about versioning. i was thinking to start with manual versioning for now and have something released using pipeline and then add tickets for versioning. we need to refine them as well and think of a strategy how we want to version our sdks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sounds good. Just a note that we have the version duplicated both here and in android { defaultConfig {} }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on syncing Github release versions with Maven versions, once we get closer to an official Maven distribution
9778429
to
7a540dd
Compare
7a540dd
to
6fb8230
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have little knowledge of jitpack
, but my understanding is that we are going to generate aar
libs to be attached to our draft releases here on GitHub. None of this is impacting the more "official" Maven publications.
As long as the above is correct, looks good to me 👍
@fabriziodemaria true. btw, it's important to not mistake jitpack with the create release step. releases of the github is a different thing than jitpack. jitpack is just a tool that lets us depend on a jvm/android lib in github. basically they do all the local checkout and localMaven stuff internally. |
add the publishing to gpr and release pipeline
add the publishing to gpr and release pipeline
add the publishing to gpr and release pipeline
add the publishing to gpr and release pipeline
add the publishing to gpr and release pipeline
add the publishing to gpr and release pipeline
add the publishing to gpr and release pipeline
add the publishing to gpr and release pipeline
or on a release