Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

add the publishing to gpr and release pipeline #25

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Conversation

vahidlazio
Copy link
Contributor

@vahidlazio vahidlazio commented Jul 7, 2023

  • create release per tag created in the main branch.
  • we can depend on openfeature sdk in the provider (on any branch/commit as following using jitpack) after merging this :
api("com.github.spotify:openfeature-kotlin-sdk:[BRANCH_NAME]-SNAPSHOT") // or commit hash

or on a release

api("com.github.spotify:openfeature-kotlin-sdk")

register<MavenPublication>("release") {
groupId = "dev.openfeature"
artifactId = "kotlin-sdk"
version = "0.0.1-SNAPSHOT"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? shouldn't we pull this from somewhere? The tag info for example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, we should think about versioning. i was thinking to start with manual versioning for now and have something released using pipeline and then add tickets for versioning. we need to refine them as well and think of a strategy how we want to version our sdks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sounds good. Just a note that we have the version duplicated both here and in android { defaultConfig {} }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on syncing Github release versions with Maven versions, once we get closer to an official Maven distribution

@vahidlazio vahidlazio force-pushed the release-pipeline branch 12 times, most recently from 9778429 to 7a540dd Compare July 12, 2023 12:03
@vahidlazio vahidlazio marked this pull request as ready for review July 12, 2023 12:13
Copy link
Member

@fabriziodemaria fabriziodemaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have little knowledge of jitpack, but my understanding is that we are going to generate aar libs to be attached to our draft releases here on GitHub. None of this is impacting the more "official" Maven publications.
As long as the above is correct, looks good to me 👍

@vahidlazio
Copy link
Contributor Author

@fabriziodemaria true. btw, it's important to not mistake jitpack with the create release step. releases of the github is a different thing than jitpack. jitpack is just a tool that lets us depend on a jvm/android lib in github. basically they do all the local checkout and localMaven stuff internally.

@vahidlazio vahidlazio merged commit e8d6b9f into main Jul 12, 2023
1 check passed
vahidlazio added a commit that referenced this pull request Jul 12, 2023
add the publishing to gpr and release pipeline
vahidlazio added a commit that referenced this pull request Jul 12, 2023
add the publishing to gpr and release pipeline
vahidlazio added a commit that referenced this pull request Jul 12, 2023
add the publishing to gpr and release pipeline
vahidlazio added a commit that referenced this pull request Jul 12, 2023
add the publishing to gpr and release pipeline
vahidlazio added a commit that referenced this pull request Jul 12, 2023
add the publishing to gpr and release pipeline
vahidlazio added a commit that referenced this pull request Jul 12, 2023
add the publishing to gpr and release pipeline
vahidlazio added a commit that referenced this pull request Jul 12, 2023
add the publishing to gpr and release pipeline
vahidlazio added a commit that referenced this pull request Jul 12, 2023
add the publishing to gpr and release pipeline
@vahidlazio vahidlazio deleted the release-pipeline branch July 13, 2023 08:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants