Raise any Python exceptions thrown during seek operations on file-lik…

…e objects. (#262)
spotify · Oct 13, 2023 · 2c35d8f · 2c35d8f
1 parent 9a92fae
commit 2c35d8f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/pedalboard/io/PythonFileLike.h b/pedalboard/io/PythonFileLike.h
@@ -109,10 +109,7 @@ class PythonFileLike {
 
     if (!PythonException::isPending()) {
       try {
-        if (fileLike.attr("seekable")().cast<bool>()) {
-          fileLike.attr("seek")(pos);
-        }
-
+        fileLike.attr("seek")(pos);
         return fileLike.attr("tell")().cast<juce::int64>() == pos;
       } catch (py::error_already_set e) {
         e.restore();

diff --git a/tests/test_io.py b/tests/test_io.py
@@ -398,6 +398,19 @@ def test_no_crash_if_type_error_on_file_like():
     assert "bool" in str(e)
 
 
+def test_file_like_must_be_seekable_for_write():
+    stream = io.BytesIO()
+    stream.seek = lambda x: (_ for _ in ()).throw(
+        ValueError(f"Failed to seek from {stream.tell():,} to {x:,} because I don't wanna")
+    )
+
+    with pytest.raises(ValueError) as e:
+        with pedalboard.io.AudioFile(stream, "w", 44100, 2, format="flac"):
+            pass
+
+    assert "I don't wanna" in str(e)
+
+
 def test_write_fails_without_extension(tmp_path: pathlib.Path):
     dest_path = str(tmp_path / "no_extension")
     with pytest.raises(ValueError):