Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to react & react-dom 16.x #124

Closed
ekh64 opened this issue Nov 30, 2018 · 1 comment
Closed

Upgrade to react & react-dom 16.x #124

ekh64 opened this issue Nov 30, 2018 · 1 comment
Assignees
@krissalvador27
Labels
enhancement taken

Comments

@ekh64
Copy link
Collaborator

ekh64 commented Nov 30, 2018

My projects are relying on React 16.4.x, and while Reactochart functions as expected, I do get a incorrect peer dependency warning on the react and react-dom modules. Reactochart appears to be working as expected, but it would be nice to have these versions of React officially supported.
@krissalvador27 krissalvador27 self-assigned this Dec 1, 2018
@krissalvador27 krissalvador27 mentioned this issue Dec 5, 2018
Merged
@krissalvador27
Copy link
Contributor

should be fixed in v1.5.0 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krissalvador27 krissalvador27

Labels
enhancement taken
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ekh64 @krissalvador27