Upgrade react #130
Merged
Upgrade react #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
krissalvador27
commented
Dec 5, 2018
krissalvador27
commented
- upgrade packages to react v16 and fix necessary dependencies (react-dom, react-test-renderer, enzyme, chai)
- reconfigure peer dependencies
- update tests after enzyme v3 upgrade
|
Addresses #124 |
joshbDev
reviewed
Dec 10, 2018
| codeText: PropTypes.string, | ||
| scope: PropTypes.object, | ||
| isExpanded: PropTypes.bool, | ||
| label: PropTypes.node, |
There was a problem hiding this comment.
are we not using proptypes in the actual code?
There was a problem hiding this comment.
we are! just updated how the ExampleSection was referencing prop-types
install
pushed a commit
that referenced
this pull request
Feb 25, 2020
* Upgrade react + peer dependencies + enzyme * Fix proptypes issue & update tests for enzyme v3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.