Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react #130

Merged
merged 2 commits into from
Dec 6, 2018
Merged

Upgrade react #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
657d6e3
Upgrade react + peer dependencies + enzyme
krissalvador27 Dec 5, 2018
5a62ad7
Fix proptypes issue & update tests for enzyme v3
krissalvador27 Dec 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions docs/src/ExampleSection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React from "react";
import ReactDOM from "react-dom";
import PropTypes from "prop-types";
import _ from "lodash";
import moment from "moment";
import * as d3 from "d3";
Expand All @@ -18,13 +19,13 @@ window.Reactochart = Reactochart;

export default class ExampleSection extends React.Component {
static propTypes = {
codeText: React.PropTypes.string,
scope: React.PropTypes.object,
isExpanded: React.PropTypes.bool,
label: React.PropTypes.node,
id: React.PropTypes.string,
description: React.PropTypes.node,
onClick: React.PropTypes.func
codeText: PropTypes.string,
scope: PropTypes.object,
isExpanded: PropTypes.bool,
label: PropTypes.node,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we not using proptypes in the actual code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are! just updated how the ExampleSection was referencing prop-types

id: PropTypes.string,
description: PropTypes.node,
onClick: PropTypes.func
};
static defaultProps = {
codeText: "",
Expand Down
Loading