Replace lodash functions with native JS versions #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
krissalvador27
added a commit
that referenced
this pull request
Aug 20, 2019
* Use Array, every and isFinite from JS native * Use some and find from JS native * Fix isFinite to check for null * Replace assign with Object.assign * Replace partial with bind * Remove console * Fix bind on XYPlot
krissalvador27
added a commit
that referenced
this pull request
Aug 22, 2019
* Use Array, every and isFinite from JS native * Use some and find from JS native * Fix isFinite to check for null * Replace assign with Object.assign * Replace partial with bind * Remove console * Fix bind on XYPlot
krissalvador27
added a commit
that referenced
this pull request
Aug 30, 2019
* 1.12.0-rc.0 * Modularize lodash (#163) * Update build process to modularize lodash * Update src files to import lodash modularly * Fix missing lodash imports and remove partial and use better bind function for tests * Update docs * Update changelog * Replace lodash functions with native JS versions (#164) * Use Array, every and isFinite from JS native * Use some and find from JS native * Fix isFinite to check for null * Replace assign with Object.assign * Replace partial with bind * Remove console * Fix bind on XYPlot * Deprecate moment in favor of d3 time format. Move getDefaultFormats to Label utils and remove from X and YAxisLabels as static functions. Update tests (#166) * Deprecate numeral.js (#169) * replace numeral in Label.jsx with d3 format * remove format prop documentation, update formats prop documentation for X and Y AxisLabels * remove props.format from X and Y Axis Labels * Remove numeral from SankeyDiagram component * removed numeral library and updated docs * add back format prop for both X and Y Axis Label components" * Add format prop back allowing only function type * Clean build with updated props docs * Updated build * Fix typo in docs * Actually fix typo * Clean build with fixed typos in docs * add testing for numeric formats passed to X and Y Axis Labels * fix typo in comment * update format documentation to mirror formats * Update XAxis and YAxis labelFormat PropType * Fix import for identity * Update X and Y axis labels examples with new formats * Update CHANGELOG.md * Namespace xy plot props (#170) * Update prop omission logic in XYPlot and change style -> xyPlotContainerStyle * Fix tests and clean up * Update format examples (#171) * Update component docs and build * Migrate to Spotify web scripts for eslint and prettier (#173) * Added packages from spotify/web-scripts * Run prettier * Eslint clean up * Run eslint on test instead of using eslint.spec.js * Fix componentdocs file * Rebuild docs * Fix tests * Update changelog * Update docs * Fix documentation props sort logic & update docs * 2.0.0-rc.1 * Update changelog for 2.0.0
install
pushed a commit
that referenced
this pull request
Feb 25, 2020
* 1.12.0-rc.0 * Modularize lodash (#163) * Update build process to modularize lodash * Update src files to import lodash modularly * Fix missing lodash imports and remove partial and use better bind function for tests * Update docs * Update changelog * Replace lodash functions with native JS versions (#164) * Use Array, every and isFinite from JS native * Use some and find from JS native * Fix isFinite to check for null * Replace assign with Object.assign * Replace partial with bind * Remove console * Fix bind on XYPlot * Deprecate moment in favor of d3 time format. Move getDefaultFormats to Label utils and remove from X and YAxisLabels as static functions. Update tests (#166) * Deprecate numeral.js (#169) * replace numeral in Label.jsx with d3 format * remove format prop documentation, update formats prop documentation for X and Y AxisLabels * remove props.format from X and Y Axis Labels * Remove numeral from SankeyDiagram component * removed numeral library and updated docs * add back format prop for both X and Y Axis Label components" * Add format prop back allowing only function type * Clean build with updated props docs * Updated build * Fix typo in docs * Actually fix typo * Clean build with fixed typos in docs * add testing for numeric formats passed to X and Y Axis Labels * fix typo in comment * update format documentation to mirror formats * Update XAxis and YAxis labelFormat PropType * Fix import for identity * Update X and Y axis labels examples with new formats * Update CHANGELOG.md * Namespace xy plot props (#170) * Update prop omission logic in XYPlot and change style -> xyPlotContainerStyle * Fix tests and clean up * Update format examples (#171) * Update component docs and build * Migrate to Spotify web scripts for eslint and prettier (#173) * Added packages from spotify/web-scripts * Run prettier * Eslint clean up * Run eslint on test instead of using eslint.spec.js * Fix componentdocs file * Rebuild docs * Fix tests * Update changelog * Update docs * Fix documentation props sort logic & update docs * 2.0.0-rc.1 * Update changelog for 2.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went through and updated a few lodash imports that could be replaced with their native counterpart. Small win and lowers our lodash dependency 🏆
related to #163 and addresses issue #159