-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pie Chart Styles #201
Add Pie Chart Styles #201
Conversation
@@ -286,7 +293,7 @@ class PieChart extends React.Component { | |||
markerLineOverhangOuter, | |||
} = this.props; | |||
|
|||
const valueAccessor = makeAccessor(this.props.getValue); | |||
const valueAccessor = makeAccessor(this.props.slice); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's de-structure slice from line 294
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slice is used a variable in multiple instances throughout the code. There are scoping conflicts when this is adjusted. I think we can stick with this.props.slice
for now.
Hey @acmei! Since this will be a breaking change, I'm going to get this into |
…t-styles * 'v3' of github.com:spotify/reactochart: Update docs based on raw-loader upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question but this looks good to me!
@@ -1,12 +1,11 @@ | |||
{ | |||
"description": "`AreaBarChart` is a variation on the standard bar chart. Just like a normal bar chart, each bar represents a single\nvalue on the *dependent* axis (Y axis for vertical bars), and the bar stretches from zero to this value.\nHowever, on the *independent* axis, each bar represents a *range* (min/max) of values,\nrather than being centered on a specific value.\nIn other words, the bar *lengths* act the same way as standard bar chart bars,\nbut their *thicknesses* are variable and meaningful.\n`AreaBarChart`s are the correct way to display histograms with variable bin sizes.\nThey are so named because, in cases like these histograms, since both the bar thickness and length are meaningful,\nso too is the bar's total *area*, unlike in other bar charts.", | |||
"displayName": "AreaBarChart", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this show up in the docs now?
@@ -60,7 +55,7 @@ | |||
"type": { | |||
"name": "array" | |||
}, | |||
"required": true, | |||
"required": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do this in future PR since this is growing in scope but because data is given a default in defaultProps, it's marked as required false even though we declare it required in PropTypes. Will create an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* 'v3' of github.com:spotify/reactochart: Add Pie Chart Styles (#201)
* Revert "Revert "Added Precommit hooks (#191)" (#193)" (#194) This reverts commit c6ae448. * Update dependencies to enable Greenkeeper 🌴 (#187) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore(package): update lockfile package-lock.json * Fix issues with cross-env upgrade * Update jsdom setup * Remove docs from npm build command * Remove support for node < 8 * Update docs based on raw-loader upgrade * Add Pie Chart Styles (#201) * WIP: PieChart prop of getValue -> slice, added pieSliceStyle prop to PieChart * replace example code color picker with d3 function * update docs * address pr comments * undo slice destructure * update docs and fix CleanWebpack package usage * doc update * docs update * remove doc build config * Doc updates (#207) * update punctuation for AreaBarChart * require data as a prop for AreaBarChart * update docs for AreaChart && add required next to props that are required * update Bar docs * update BarChart docs * update ColorHeatmap docs * FunnelChart docs * update FunnelChart docs * update Histogram docs * update KernelDensityEstimation docs * update LineChart docs * MarkerLineChart docs update * RangeBarChart doc update * add iteration through enum types for docs, update sankey diagram docs * remove extra spaces * update docs for TreeMap * Bar doc updates * update all the docs with more descriptive prop types * docs update for XLine * update the rest of the docs
* Changelog casing fix * decorate events and remove original decorations (#182) * Fix warnings in tests and add SankeyNodeTerminal tests (#184) * Update event handler test on XYPlot * Fix Bar warnings in tests * Fix XLine warnings in tests * Fix AreaBarChart warnings * Update SankeyDiagram tests * Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <support@github.com> * Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <support@github.com> * 2.0.2 release (#188) * 2.0.2 release * Update package-lock * 2.0.2 * Update docs in master (#189) * Update docs * rebuild docs * Update docs * Update docs * Added Precommit hooks (#191) * Added Precommit hooks * Update package.json for precommit hooks * Remove docs from build (#192) * Update package-lock.json * Remove docs from build process * Disable cache for travis builds * Revert "Added Precommit hooks (#191)" (#193) This reverts commit 777320a. * v3.0.0 release (#195) * Revert "Revert "Added Precommit hooks (#191)" (#193)" (#194) This reverts commit c6ae448. * Update dependencies to enable Greenkeeper 🌴 (#187) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore(package): update lockfile package-lock.json * Fix issues with cross-env upgrade * Update jsdom setup * Remove docs from npm build command * Remove support for node < 8 * Update docs based on raw-loader upgrade * Add Pie Chart Styles (#201) * WIP: PieChart prop of getValue -> slice, added pieSliceStyle prop to PieChart * replace example code color picker with d3 function * update docs * address pr comments * undo slice destructure * update docs and fix CleanWebpack package usage * doc update * docs update * remove doc build config * Doc updates (#207) * update punctuation for AreaBarChart * require data as a prop for AreaBarChart * update docs for AreaChart && add required next to props that are required * update Bar docs * update BarChart docs * update ColorHeatmap docs * FunnelChart docs * update FunnelChart docs * update Histogram docs * update KernelDensityEstimation docs * update LineChart docs * MarkerLineChart docs update * RangeBarChart doc update * add iteration through enum types for docs, update sankey diagram docs * remove extra spaces * update docs for TreeMap * Bar doc updates * update all the docs with more descriptive prop types * docs update for XLine * update the rest of the docs * 3.0.0 * v3.0.0 release
* Changelog casing fix * decorate events and remove original decorations (#182) * Fix warnings in tests and add SankeyNodeTerminal tests (#184) * Update event handler test on XYPlot * Fix Bar warnings in tests * Fix XLine warnings in tests * Fix AreaBarChart warnings * Update SankeyDiagram tests * Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <support@github.com> * Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <support@github.com> * 2.0.2 release (#188) * 2.0.2 release * Update package-lock * 2.0.2 * Update docs in master (#189) * Update docs * rebuild docs * Update docs * Update docs * Added Precommit hooks (#191) * Added Precommit hooks * Update package.json for precommit hooks * Remove docs from build (#192) * Update package-lock.json * Remove docs from build process * Disable cache for travis builds * Revert "Added Precommit hooks (#191)" (#193) This reverts commit 777320a. * v3.0.0 release (#195) * Revert "Revert "Added Precommit hooks (#191)" (#193)" (#194) This reverts commit c6ae448. * Update dependencies to enable Greenkeeper 🌴 (#187) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore(package): update lockfile package-lock.json * Fix issues with cross-env upgrade * Update jsdom setup * Remove docs from npm build command * Remove support for node < 8 * Update docs based on raw-loader upgrade * Add Pie Chart Styles (#201) * WIP: PieChart prop of getValue -> slice, added pieSliceStyle prop to PieChart * replace example code color picker with d3 function * update docs * address pr comments * undo slice destructure * update docs and fix CleanWebpack package usage * doc update * docs update * remove doc build config * Doc updates (#207) * update punctuation for AreaBarChart * require data as a prop for AreaBarChart * update docs for AreaChart && add required next to props that are required * update Bar docs * update BarChart docs * update ColorHeatmap docs * FunnelChart docs * update FunnelChart docs * update Histogram docs * update KernelDensityEstimation docs * update LineChart docs * MarkerLineChart docs update * RangeBarChart doc update * add iteration through enum types for docs, update sankey diagram docs * remove extra spaces * update docs for TreeMap * Bar doc updates * update all the docs with more descriptive prop types * docs update for XLine * update the rest of the docs * 3.0.0 * v3.0.0 release * Fix xy plot lesson in docs (#211) * Fix xy plot lesson in docs * Add TODO regarding Interaction and GettersAndAccessors lesson and fix those imports just in case * Prettier ignore build (#212) * Add prettierignore to ignore build files * ignore node modules * 3.0.1 * v3.0.1 release
* Revert "Revert "Added Precommit hooks (#191)" (#193)" (#194) This reverts commit c6ae448. * Update dependencies to enable Greenkeeper 🌴 (#187) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore(package): update lockfile package-lock.json * Fix issues with cross-env upgrade * Update jsdom setup * Remove docs from npm build command * Remove support for node < 8 * Update docs based on raw-loader upgrade * Add Pie Chart Styles (#201) * WIP: PieChart prop of getValue -> slice, added pieSliceStyle prop to PieChart * replace example code color picker with d3 function * update docs * address pr comments * undo slice destructure * update docs and fix CleanWebpack package usage * doc update * docs update * remove doc build config * Doc updates (#207) * update punctuation for AreaBarChart * require data as a prop for AreaBarChart * update docs for AreaChart && add required next to props that are required * update Bar docs * update BarChart docs * update ColorHeatmap docs * FunnelChart docs * update FunnelChart docs * update Histogram docs * update KernelDensityEstimation docs * update LineChart docs * MarkerLineChart docs update * RangeBarChart doc update * add iteration through enum types for docs, update sankey diagram docs * remove extra spaces * update docs for TreeMap * Bar doc updates * update all the docs with more descriptive prop types * docs update for XLine * update the rest of the docs
* Changelog casing fix * decorate events and remove original decorations (#182) * Fix warnings in tests and add SankeyNodeTerminal tests (#184) * Update event handler test on XYPlot * Fix Bar warnings in tests * Fix XLine warnings in tests * Fix AreaBarChart warnings * Update SankeyDiagram tests * Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <support@github.com> * Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <support@github.com> * 2.0.2 release (#188) * 2.0.2 release * Update package-lock * 2.0.2 * Update docs in master (#189) * Update docs * rebuild docs * Update docs * Update docs * Added Precommit hooks (#191) * Added Precommit hooks * Update package.json for precommit hooks * Remove docs from build (#192) * Update package-lock.json * Remove docs from build process * Disable cache for travis builds * Revert "Added Precommit hooks (#191)" (#193) This reverts commit 777320a. * v3.0.0 release (#195) * Revert "Revert "Added Precommit hooks (#191)" (#193)" (#194) This reverts commit c6ae448. * Update dependencies to enable Greenkeeper 🌴 (#187) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore(package): update lockfile package-lock.json * Fix issues with cross-env upgrade * Update jsdom setup * Remove docs from npm build command * Remove support for node < 8 * Update docs based on raw-loader upgrade * Add Pie Chart Styles (#201) * WIP: PieChart prop of getValue -> slice, added pieSliceStyle prop to PieChart * replace example code color picker with d3 function * update docs * address pr comments * undo slice destructure * update docs and fix CleanWebpack package usage * doc update * docs update * remove doc build config * Doc updates (#207) * update punctuation for AreaBarChart * require data as a prop for AreaBarChart * update docs for AreaChart && add required next to props that are required * update Bar docs * update BarChart docs * update ColorHeatmap docs * FunnelChart docs * update FunnelChart docs * update Histogram docs * update KernelDensityEstimation docs * update LineChart docs * MarkerLineChart docs update * RangeBarChart doc update * add iteration through enum types for docs, update sankey diagram docs * remove extra spaces * update docs for TreeMap * Bar doc updates * update all the docs with more descriptive prop types * docs update for XLine * update the rest of the docs * 3.0.0 * v3.0.0 release * Fix xy plot lesson in docs (#211) * Fix xy plot lesson in docs * Add TODO regarding Interaction and GettersAndAccessors lesson and fix those imports just in case * Prettier ignore build (#212) * Add prettierignore to ignore build files * ignore node modules * 3.0.1 * v3.0.1 release * Update sinon to the latest version 🚀 (#216) * chore(package): update sinon to version 8.0.0 * chore(package): update lockfile package-lock.json * Update eslint-config-prettier to the latest version 🚀 (#217) * chore(package): update eslint-config-prettier to version 6.8.0 * chore(package): update lockfile package-lock.json * Update cross-env to the latest version 🚀 (#225) * chore(package): update cross-env to version 7.0.0 * chore(package): update lockfile package-lock.json * Update mocha to the latest version 🚀 (#226) * chore(package): update mocha to version 7.0.1 * chore(package): update lockfile package-lock.json * Rename upcoming deprecated Lifecycle methods (#214) * rename lifecycle methods in src * update examples * fix weird prettier stuff * Greenkeeper/@spotify/eslint config base 6.0.0 (#227) * chore(package): update @spotify/eslint-config-base to version 6.0.0 Closes #219 * chore(package): update lockfile package-lock.json Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> * Greenkeeper/@spotify/prettier config 6.0.0 (#230) * chore(package): update @spotify/prettier-config to version 6.0.0 Closes #221 * chore(package): update lockfile package-lock.json Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> * Greenkeeper/@spotify/eslint config react 6.0.0 (#228) * chore(package): update @spotify/eslint-config-react to version 6.0.0 Closes #220 * chore(package): update lockfile package-lock.json * fix lint errors Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> * Remove deprecated Lifecycle hooks (#234) * remove unsafe calls from animated examples * remove unsafe calls from TreeMap * remove unsafe calls from KernelDensityEstimation * remove unsafe calls from LineChart * remove Unsafe calls from SankeyDiagram * remove deprecated lifecycle hooks from ZoomContainer * 3.0.2 * v3.0.2 release Co-authored-by: Kris Salvador <krissalvador27@gmail.com> Co-authored-by: Tanay Vardhan <tvardha2@illinois.edu> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anita <acmei@users.noreply.github.com> Co-authored-by: Ian MacIntosh <ianjmacintosh@users.noreply.github.com> Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> Co-authored-by: Erica Hyman <ekhyman@gmail.com>
* Update docs * rebuild docs * Update docs * Update docs (#190) * Changelog casing fix * decorate events and remove original decorations (#182) * Fix warnings in tests and add SankeyNodeTerminal tests (#184) * Update event handler test on XYPlot * Fix Bar warnings in tests * Fix XLine warnings in tests * Fix AreaBarChart warnings * Update SankeyDiagram tests * Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <support@github.com> * Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <support@github.com> * 2.0.2 release (#188) * 2.0.2 release * Update package-lock * 2.0.2 * Update docs * Gh pages v3 (#210) * Changelog casing fix * decorate events and remove original decorations (#182) * Fix warnings in tests and add SankeyNodeTerminal tests (#184) * Update event handler test on XYPlot * Fix Bar warnings in tests * Fix XLine warnings in tests * Fix AreaBarChart warnings * Update SankeyDiagram tests * Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <support@github.com> * Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <support@github.com> * 2.0.2 release (#188) * 2.0.2 release * Update package-lock * 2.0.2 * Update docs in master (#189) * Update docs * rebuild docs * Update docs * Update docs * Added Precommit hooks (#191) * Added Precommit hooks * Update package.json for precommit hooks * Remove docs from build (#192) * Update package-lock.json * Remove docs from build process * Disable cache for travis builds * Revert "Added Precommit hooks (#191)" (#193) This reverts commit 777320a. * v3.0.0 release (#195) * Revert "Revert "Added Precommit hooks (#191)" (#193)" (#194) This reverts commit c6ae448. * Update dependencies to enable Greenkeeper 🌴 (#187) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore(package): update lockfile package-lock.json * Fix issues with cross-env upgrade * Update jsdom setup * Remove docs from npm build command * Remove support for node < 8 * Update docs based on raw-loader upgrade * Add Pie Chart Styles (#201) * WIP: PieChart prop of getValue -> slice, added pieSliceStyle prop to PieChart * replace example code color picker with d3 function * update docs * address pr comments * undo slice destructure * update docs and fix CleanWebpack package usage * doc update * docs update * remove doc build config * Doc updates (#207) * update punctuation for AreaBarChart * require data as a prop for AreaBarChart * update docs for AreaChart && add required next to props that are required * update Bar docs * update BarChart docs * update ColorHeatmap docs * FunnelChart docs * update FunnelChart docs * update Histogram docs * update KernelDensityEstimation docs * update LineChart docs * MarkerLineChart docs update * RangeBarChart doc update * add iteration through enum types for docs, update sankey diagram docs * remove extra spaces * update docs for TreeMap * Bar doc updates * update all the docs with more descriptive prop types * docs update for XLine * update the rest of the docs * 3.0.0 * v3.0.0 release * Gh pages v3 0 1 (#213) * Changelog casing fix * decorate events and remove original decorations (#182) * Fix warnings in tests and add SankeyNodeTerminal tests (#184) * Update event handler test on XYPlot * Fix Bar warnings in tests * Fix XLine warnings in tests * Fix AreaBarChart warnings * Update SankeyDiagram tests * Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <support@github.com> * Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <support@github.com> * 2.0.2 release (#188) * 2.0.2 release * Update package-lock * 2.0.2 * Update docs in master (#189) * Update docs * rebuild docs * Update docs * Update docs * Added Precommit hooks (#191) * Added Precommit hooks * Update package.json for precommit hooks * Remove docs from build (#192) * Update package-lock.json * Remove docs from build process * Disable cache for travis builds * Revert "Added Precommit hooks (#191)" (#193) This reverts commit 777320a. * v3.0.0 release (#195) * Revert "Revert "Added Precommit hooks (#191)" (#193)" (#194) This reverts commit c6ae448. * Update dependencies to enable Greenkeeper 🌴 (#187) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore(package): update lockfile package-lock.json * Fix issues with cross-env upgrade * Update jsdom setup * Remove docs from npm build command * Remove support for node < 8 * Update docs based on raw-loader upgrade * Add Pie Chart Styles (#201) * WIP: PieChart prop of getValue -> slice, added pieSliceStyle prop to PieChart * replace example code color picker with d3 function * update docs * address pr comments * undo slice destructure * update docs and fix CleanWebpack package usage * doc update * docs update * remove doc build config * Doc updates (#207) * update punctuation for AreaBarChart * require data as a prop for AreaBarChart * update docs for AreaChart && add required next to props that are required * update Bar docs * update BarChart docs * update ColorHeatmap docs * FunnelChart docs * update FunnelChart docs * update Histogram docs * update KernelDensityEstimation docs * update LineChart docs * MarkerLineChart docs update * RangeBarChart doc update * add iteration through enum types for docs, update sankey diagram docs * remove extra spaces * update docs for TreeMap * Bar doc updates * update all the docs with more descriptive prop types * docs update for XLine * update the rest of the docs * 3.0.0 * v3.0.0 release * Fix xy plot lesson in docs (#211) * Fix xy plot lesson in docs * Add TODO regarding Interaction and GettersAndAccessors lesson and fix those imports just in case * Prettier ignore build (#212) * Add prettierignore to ignore build files * ignore node modules * 3.0.1 * v3.0.1 release * Gh pages v3.0.2 (#237) * Changelog casing fix * decorate events and remove original decorations (#182) * Fix warnings in tests and add SankeyNodeTerminal tests (#184) * Update event handler test on XYPlot * Fix Bar warnings in tests * Fix XLine warnings in tests * Fix AreaBarChart warnings * Update SankeyDiagram tests * Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <support@github.com> * Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <support@github.com> * 2.0.2 release (#188) * 2.0.2 release * Update package-lock * 2.0.2 * Update docs in master (#189) * Update docs * rebuild docs * Update docs * Update docs * Added Precommit hooks (#191) * Added Precommit hooks * Update package.json for precommit hooks * Remove docs from build (#192) * Update package-lock.json * Remove docs from build process * Disable cache for travis builds * Revert "Added Precommit hooks (#191)" (#193) This reverts commit 777320a. * v3.0.0 release (#195) * Revert "Revert "Added Precommit hooks (#191)" (#193)" (#194) This reverts commit c6ae448. * Update dependencies to enable Greenkeeper 🌴 (#187) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore(package): update lockfile package-lock.json * Fix issues with cross-env upgrade * Update jsdom setup * Remove docs from npm build command * Remove support for node < 8 * Update docs based on raw-loader upgrade * Add Pie Chart Styles (#201) * WIP: PieChart prop of getValue -> slice, added pieSliceStyle prop to PieChart * replace example code color picker with d3 function * update docs * address pr comments * undo slice destructure * update docs and fix CleanWebpack package usage * doc update * docs update * remove doc build config * Doc updates (#207) * update punctuation for AreaBarChart * require data as a prop for AreaBarChart * update docs for AreaChart && add required next to props that are required * update Bar docs * update BarChart docs * update ColorHeatmap docs * FunnelChart docs * update FunnelChart docs * update Histogram docs * update KernelDensityEstimation docs * update LineChart docs * MarkerLineChart docs update * RangeBarChart doc update * add iteration through enum types for docs, update sankey diagram docs * remove extra spaces * update docs for TreeMap * Bar doc updates * update all the docs with more descriptive prop types * docs update for XLine * update the rest of the docs * 3.0.0 * v3.0.0 release * Fix xy plot lesson in docs (#211) * Fix xy plot lesson in docs * Add TODO regarding Interaction and GettersAndAccessors lesson and fix those imports just in case * Prettier ignore build (#212) * Add prettierignore to ignore build files * ignore node modules * 3.0.1 * v3.0.1 release * Update sinon to the latest version 🚀 (#216) * chore(package): update sinon to version 8.0.0 * chore(package): update lockfile package-lock.json * Update eslint-config-prettier to the latest version 🚀 (#217) * chore(package): update eslint-config-prettier to version 6.8.0 * chore(package): update lockfile package-lock.json * Update cross-env to the latest version 🚀 (#225) * chore(package): update cross-env to version 7.0.0 * chore(package): update lockfile package-lock.json * Update mocha to the latest version 🚀 (#226) * chore(package): update mocha to version 7.0.1 * chore(package): update lockfile package-lock.json * Rename upcoming deprecated Lifecycle methods (#214) * rename lifecycle methods in src * update examples * fix weird prettier stuff * Greenkeeper/@spotify/eslint config base 6.0.0 (#227) * chore(package): update @spotify/eslint-config-base to version 6.0.0 Closes #219 * chore(package): update lockfile package-lock.json Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> * Greenkeeper/@spotify/prettier config 6.0.0 (#230) * chore(package): update @spotify/prettier-config to version 6.0.0 Closes #221 * chore(package): update lockfile package-lock.json Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> * Greenkeeper/@spotify/eslint config react 6.0.0 (#228) * chore(package): update @spotify/eslint-config-react to version 6.0.0 Closes #220 * chore(package): update lockfile package-lock.json * fix lint errors Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> * Remove deprecated Lifecycle hooks (#234) * remove unsafe calls from animated examples * remove unsafe calls from TreeMap * remove unsafe calls from KernelDensityEstimation * remove unsafe calls from LineChart * remove Unsafe calls from SankeyDiagram * remove deprecated lifecycle hooks from ZoomContainer * 3.0.2 * v3.0.2 release Co-authored-by: Kris Salvador <krissalvador27@gmail.com> Co-authored-by: Tanay Vardhan <tvardha2@illinois.edu> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anita <acmei@users.noreply.github.com> Co-authored-by: Ian MacIntosh <ianjmacintosh@users.noreply.github.com> Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> Co-authored-by: Erica Hyman <ekhyman@gmail.com> * docs Co-authored-by: Kris Salvador <krissalvador27@gmail.com> Co-authored-by: Isaac Ezer <isaac.ezer@gmail.com> Co-authored-by: Tanay Vardhan <tvardha2@illinois.edu> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ian MacIntosh <ianjmacintosh@users.noreply.github.com> Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> Co-authored-by: Erica Hyman <ekhyman@gmail.com>
* Update docs * rebuild docs * Update docs * Update docs (#190) * Changelog casing fix * decorate events and remove original decorations (#182) * Fix warnings in tests and add SankeyNodeTerminal tests (#184) * Update event handler test on XYPlot * Fix Bar warnings in tests * Fix XLine warnings in tests * Fix AreaBarChart warnings * Update SankeyDiagram tests * Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <support@github.com> * Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <support@github.com> * 2.0.2 release (#188) * 2.0.2 release * Update package-lock * 2.0.2 * Update docs * Gh pages v3 (#210) * Changelog casing fix * decorate events and remove original decorations (#182) * Fix warnings in tests and add SankeyNodeTerminal tests (#184) * Update event handler test on XYPlot * Fix Bar warnings in tests * Fix XLine warnings in tests * Fix AreaBarChart warnings * Update SankeyDiagram tests * Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <support@github.com> * Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <support@github.com> * 2.0.2 release (#188) * 2.0.2 release * Update package-lock * 2.0.2 * Update docs in master (#189) * Update docs * rebuild docs * Update docs * Update docs * Added Precommit hooks (#191) * Added Precommit hooks * Update package.json for precommit hooks * Remove docs from build (#192) * Update package-lock.json * Remove docs from build process * Disable cache for travis builds * Revert "Added Precommit hooks (#191)" (#193) This reverts commit 777320a. * v3.0.0 release (#195) * Revert "Revert "Added Precommit hooks (#191)" (#193)" (#194) This reverts commit c6ae448. * Update dependencies to enable Greenkeeper 🌴 (#187) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore(package): update lockfile package-lock.json * Fix issues with cross-env upgrade * Update jsdom setup * Remove docs from npm build command * Remove support for node < 8 * Update docs based on raw-loader upgrade * Add Pie Chart Styles (#201) * WIP: PieChart prop of getValue -> slice, added pieSliceStyle prop to PieChart * replace example code color picker with d3 function * update docs * address pr comments * undo slice destructure * update docs and fix CleanWebpack package usage * doc update * docs update * remove doc build config * Doc updates (#207) * update punctuation for AreaBarChart * require data as a prop for AreaBarChart * update docs for AreaChart && add required next to props that are required * update Bar docs * update BarChart docs * update ColorHeatmap docs * FunnelChart docs * update FunnelChart docs * update Histogram docs * update KernelDensityEstimation docs * update LineChart docs * MarkerLineChart docs update * RangeBarChart doc update * add iteration through enum types for docs, update sankey diagram docs * remove extra spaces * update docs for TreeMap * Bar doc updates * update all the docs with more descriptive prop types * docs update for XLine * update the rest of the docs * 3.0.0 * v3.0.0 release * Gh pages v3 0 1 (#213) * Changelog casing fix * decorate events and remove original decorations (#182) * Fix warnings in tests and add SankeyNodeTerminal tests (#184) * Update event handler test on XYPlot * Fix Bar warnings in tests * Fix XLine warnings in tests * Fix AreaBarChart warnings * Update SankeyDiagram tests * Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <support@github.com> * Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <support@github.com> * 2.0.2 release (#188) * 2.0.2 release * Update package-lock * 2.0.2 * Update docs in master (#189) * Update docs * rebuild docs * Update docs * Update docs * Added Precommit hooks (#191) * Added Precommit hooks * Update package.json for precommit hooks * Remove docs from build (#192) * Update package-lock.json * Remove docs from build process * Disable cache for travis builds * Revert "Added Precommit hooks (#191)" (#193) This reverts commit 777320a. * v3.0.0 release (#195) * Revert "Revert "Added Precommit hooks (#191)" (#193)" (#194) This reverts commit c6ae448. * Update dependencies to enable Greenkeeper 🌴 (#187) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore(package): update lockfile package-lock.json * Fix issues with cross-env upgrade * Update jsdom setup * Remove docs from npm build command * Remove support for node < 8 * Update docs based on raw-loader upgrade * Add Pie Chart Styles (#201) * WIP: PieChart prop of getValue -> slice, added pieSliceStyle prop to PieChart * replace example code color picker with d3 function * update docs * address pr comments * undo slice destructure * update docs and fix CleanWebpack package usage * doc update * docs update * remove doc build config * Doc updates (#207) * update punctuation for AreaBarChart * require data as a prop for AreaBarChart * update docs for AreaChart && add required next to props that are required * update Bar docs * update BarChart docs * update ColorHeatmap docs * FunnelChart docs * update FunnelChart docs * update Histogram docs * update KernelDensityEstimation docs * update LineChart docs * MarkerLineChart docs update * RangeBarChart doc update * add iteration through enum types for docs, update sankey diagram docs * remove extra spaces * update docs for TreeMap * Bar doc updates * update all the docs with more descriptive prop types * docs update for XLine * update the rest of the docs * 3.0.0 * v3.0.0 release * Fix xy plot lesson in docs (#211) * Fix xy plot lesson in docs * Add TODO regarding Interaction and GettersAndAccessors lesson and fix those imports just in case * Prettier ignore build (#212) * Add prettierignore to ignore build files * ignore node modules * 3.0.1 * v3.0.1 release * Gh pages v3.0.2 (#237) * Changelog casing fix * decorate events and remove original decorations (#182) * Fix warnings in tests and add SankeyNodeTerminal tests (#184) * Update event handler test on XYPlot * Fix Bar warnings in tests * Fix XLine warnings in tests * Fix AreaBarChart warnings * Update SankeyDiagram tests * Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <support@github.com> * Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <support@github.com> * 2.0.2 release (#188) * 2.0.2 release * Update package-lock * 2.0.2 * Update docs in master (#189) * Update docs * rebuild docs * Update docs * Update docs * Added Precommit hooks (#191) * Added Precommit hooks * Update package.json for precommit hooks * Remove docs from build (#192) * Update package-lock.json * Remove docs from build process * Disable cache for travis builds * Revert "Added Precommit hooks (#191)" (#193) This reverts commit 777320a. * v3.0.0 release (#195) * Revert "Revert "Added Precommit hooks (#191)" (#193)" (#194) This reverts commit c6ae448. * Update dependencies to enable Greenkeeper 🌴 (#187) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore(package): update lockfile package-lock.json * Fix issues with cross-env upgrade * Update jsdom setup * Remove docs from npm build command * Remove support for node < 8 * Update docs based on raw-loader upgrade * Add Pie Chart Styles (#201) * WIP: PieChart prop of getValue -> slice, added pieSliceStyle prop to PieChart * replace example code color picker with d3 function * update docs * address pr comments * undo slice destructure * update docs and fix CleanWebpack package usage * doc update * docs update * remove doc build config * Doc updates (#207) * update punctuation for AreaBarChart * require data as a prop for AreaBarChart * update docs for AreaChart && add required next to props that are required * update Bar docs * update BarChart docs * update ColorHeatmap docs * FunnelChart docs * update FunnelChart docs * update Histogram docs * update KernelDensityEstimation docs * update LineChart docs * MarkerLineChart docs update * RangeBarChart doc update * add iteration through enum types for docs, update sankey diagram docs * remove extra spaces * update docs for TreeMap * Bar doc updates * update all the docs with more descriptive prop types * docs update for XLine * update the rest of the docs * 3.0.0 * v3.0.0 release * Fix xy plot lesson in docs (#211) * Fix xy plot lesson in docs * Add TODO regarding Interaction and GettersAndAccessors lesson and fix those imports just in case * Prettier ignore build (#212) * Add prettierignore to ignore build files * ignore node modules * 3.0.1 * v3.0.1 release * Update sinon to the latest version 🚀 (#216) * chore(package): update sinon to version 8.0.0 * chore(package): update lockfile package-lock.json * Update eslint-config-prettier to the latest version 🚀 (#217) * chore(package): update eslint-config-prettier to version 6.8.0 * chore(package): update lockfile package-lock.json * Update cross-env to the latest version 🚀 (#225) * chore(package): update cross-env to version 7.0.0 * chore(package): update lockfile package-lock.json * Update mocha to the latest version 🚀 (#226) * chore(package): update mocha to version 7.0.1 * chore(package): update lockfile package-lock.json * Rename upcoming deprecated Lifecycle methods (#214) * rename lifecycle methods in src * update examples * fix weird prettier stuff * Greenkeeper/@spotify/eslint config base 6.0.0 (#227) * chore(package): update @spotify/eslint-config-base to version 6.0.0 Closes #219 * chore(package): update lockfile package-lock.json Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> * Greenkeeper/@spotify/prettier config 6.0.0 (#230) * chore(package): update @spotify/prettier-config to version 6.0.0 Closes #221 * chore(package): update lockfile package-lock.json Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> * Greenkeeper/@spotify/eslint config react 6.0.0 (#228) * chore(package): update @spotify/eslint-config-react to version 6.0.0 Closes #220 * chore(package): update lockfile package-lock.json * fix lint errors Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> * Remove deprecated Lifecycle hooks (#234) * remove unsafe calls from animated examples * remove unsafe calls from TreeMap * remove unsafe calls from KernelDensityEstimation * remove unsafe calls from LineChart * remove Unsafe calls from SankeyDiagram * remove deprecated lifecycle hooks from ZoomContainer * 3.0.2 * v3.0.2 release Co-authored-by: Kris Salvador <krissalvador27@gmail.com> Co-authored-by: Tanay Vardhan <tvardha2@illinois.edu> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anita <acmei@users.noreply.github.com> Co-authored-by: Ian MacIntosh <ianjmacintosh@users.noreply.github.com> Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> Co-authored-by: Erica Hyman <ekhyman@gmail.com> * add CODEOWNERS file (#262) * Bump elliptic from 6.5.2 to 6.5.3 (#266) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.2...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * bar chart gradient example in docs (#268) Co-authored-by: Isaac Ezer <isaace@spotify.com> * Sankey sorting (#269) * remove deprecated refs definition This old usage of defining refs via a string is deprecated and seems to break when debugging reactochart using `npm link` locally. * add Sankey Sorting Function hooks Co-authored-by: Isaac Ezer <isaace@spotify.com> * 3.2.0 * v3.2.0 release * Fix YAxisLabels formatting example (#271) The current example did not demonstrate label color/weight change, since the final label (`label.text`) never was `20.00`. * 3.2.1 * 3.2.1 release * [A11y] add aria-hidden attributes to XYPlot (#273) * add aria-hidden attributes to XYPlot elements * more granual application of aria-hidden * 3.2.2 * Add changelog edit for 3.2.2 * v3.2.2 release * v3.2.2 release * fix docs build file Co-authored-by: Kris Salvador <krissalvador27@gmail.com> Co-authored-by: Isaac Ezer <isaac.ezer@gmail.com> Co-authored-by: Tanay Vardhan <tvardha2@illinois.edu> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ian MacIntosh <ianjmacintosh@users.noreply.github.com> Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> Co-authored-by: Erica Hyman <ekhyman@gmail.com> Co-authored-by: Isaac Ezer <isaace@spotify.com> Co-authored-by: Marko Bonaći <mbonaci@users.noreply.github.com>
slice
andpieSliceStyle
toPieChart
componentslice
as a propPieChart
to be on next line from code comment and add description for new propPieChart
example file to demonstrate styling for slicesslice
toPieChart
example