Feature/arackis/make work with d3 v7 #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arackaf
requested review from
acmei,
ekh64,
iezer and
scottsheffield
as code owners
|
Hmm, I took a peek at the precommit hook, we're just using the default Spotify Web-Scripts precommit hook, so we're not doing anything fancy. And on a different branch, I haven't had problems committing changes, but I can have a look separately. |
|
I'm currently attempting to figure out why our CI isn't running, so let me dig around on that for now and then I'll merge. NOTE: I'm going on vacation until after Labor Day, so if I don't merge + version bump today, it'll have to wait until I return after 9/8 |
arackaf
force-pushed
the
feature/arackis/make-work-with-d3-v7
branch
from
85f051a to
d0aed21
Compare
ekh64
added a commit
that referenced
this pull request
Sep 10, 2021
* add CODEOWNERS file (#262) * Bump elliptic from 6.5.2 to 6.5.3 (#266) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.2...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * bar chart gradient example in docs (#268) Co-authored-by: Isaac Ezer <isaace@spotify.com> * Sankey sorting (#269) * remove deprecated refs definition This old usage of defining refs via a string is deprecated and seems to break when debugging reactochart using `npm link` locally. * add Sankey Sorting Function hooks Co-authored-by: Isaac Ezer <isaace@spotify.com> * 3.2.0 * v3.2.0 release * Fix YAxisLabels formatting example (#271) The current example did not demonstrate label color/weight change, since the final label (`label.text`) never was `20.00`. * 3.2.1 * 3.2.1 release * [A11y] add aria-hidden attributes to XYPlot (#273) * add aria-hidden attributes to XYPlot elements * more granual application of aria-hidden * 3.2.2 * Add changelog edit for 3.2.2 * v3.2.2 release * v3.2.2 release * Upgrade D3 6.3.1 (#276) * d3 6.0 * update imports * make all the things prettier * restrict d3 import * remove global d3 imports from specs Co-authored-by: Isaac Ezer <isaace@spotify.com> * 4.0.0 * v4.0.0 release * remove old node versions. Support >=12 (#287) * remove old node versions. Support >=12 * auto fix audit errors * remove node 16, build failing * update package-lock.json Co-authored-by: Isaac Ezer <isaace@spotify.com> * Bump lodash from 4.17.15 to 4.17.21 (#285) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.21) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump elliptic from 6.5.3 to 6.5.4 (#278) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.3...v6.5.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 5.0.0 * v5.0.0 release * Migrate jsdom tests to jest (#291) * Create dependabot.yml * [Infra] Enable a Github Action for CI (#308) * Create node.js.yml * remove browser test step * CI test * Revert "CI test" This reverts commit b2c894a. * Feature/arackis/make work with d3 v7 (#307) * Install d3, update Jest to transpile d3 * Fix unit tests - negative numbers were using the wrong negative unicode character * Include d3@6 as acceptable * Undo whitespace changes in jest config * fix lockfile * 6.0.0 * v6.0.0 release Co-authored-by: Anita <acmei@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Isaac Ezer <isaac.ezer@gmail.com> Co-authored-by: Isaac Ezer <isaace@spotify.com> Co-authored-by: Marko Bonaći <mbonaci@users.noreply.github.com> Co-authored-by: Anita Wang <anitaw@spotify.com> Co-authored-by: Markus Wagner <71727154+PRTTMPRPHT@users.noreply.github.com> Co-authored-by: Adam Rackis <arackaf@users.noreply.github.com>
iezer
pushed a commit
that referenced
this pull request
Jan 19, 2022
* add CODEOWNERS file (#262) * Bump elliptic from 6.5.2 to 6.5.3 (#266) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.2...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * bar chart gradient example in docs (#268) Co-authored-by: Isaac Ezer <isaace@spotify.com> * Sankey sorting (#269) * remove deprecated refs definition This old usage of defining refs via a string is deprecated and seems to break when debugging reactochart using `npm link` locally. * add Sankey Sorting Function hooks Co-authored-by: Isaac Ezer <isaace@spotify.com> * 3.2.0 * v3.2.0 release * Fix YAxisLabels formatting example (#271) The current example did not demonstrate label color/weight change, since the final label (`label.text`) never was `20.00`. * 3.2.1 * 3.2.1 release * [A11y] add aria-hidden attributes to XYPlot (#273) * add aria-hidden attributes to XYPlot elements * more granual application of aria-hidden * 3.2.2 * Add changelog edit for 3.2.2 * v3.2.2 release * v3.2.2 release * Upgrade D3 6.3.1 (#276) * d3 6.0 * update imports * make all the things prettier * restrict d3 import * remove global d3 imports from specs Co-authored-by: Isaac Ezer <isaace@spotify.com> * 4.0.0 * v4.0.0 release * remove old node versions. Support >=12 (#287) * remove old node versions. Support >=12 * auto fix audit errors * remove node 16, build failing * update package-lock.json Co-authored-by: Isaac Ezer <isaace@spotify.com> * Bump lodash from 4.17.15 to 4.17.21 (#285) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.21) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump elliptic from 6.5.3 to 6.5.4 (#278) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.3...v6.5.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 5.0.0 * v5.0.0 release * Migrate jsdom tests to jest (#291) * Create dependabot.yml * [Infra] Enable a Github Action for CI (#308) * Create node.js.yml * remove browser test step * CI test * Revert "CI test" This reverts commit b2c894a. * Feature/arackis/make work with d3 v7 (#307) * Install d3, update Jest to transpile d3 * Fix unit tests - negative numbers were using the wrong negative unicode character * Include d3@6 as acceptable * Undo whitespace changes in jest config * fix lockfile * 6.0.0 * v6.0.0 release * Accessible Interface for Line/Area Charts (#294) * A11yInterface in reactochart * npm run make-docs + render A11yInterface docs * fix offset bug + more examples * refactor for simplicity * revert the styling since the outline wasn't a problem * A11yInterface Tests * refactor to use datasetsWithAccessor instead * rename + doc generation * wip: refactor of AriaLabelContainer * fix an example, fix bug with chart * fix my examples & refactor again * update package-lock * 6.1.0 * v6.1.0 release Co-authored-by: Anita <acmei@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marko Bonaći <mbonaci@users.noreply.github.com> Co-authored-by: Erica Hyman <ekhyman@gmail.com> Co-authored-by: Anita Wang <anitaw@spotify.com> Co-authored-by: Markus Wagner <71727154+PRTTMPRPHT@users.noreply.github.com> Co-authored-by: Adam Rackis <arackaf@users.noreply.github.com>
ekh64
added a commit
that referenced
this pull request
Nov 18, 2022
* add CODEOWNERS file (#262) * Bump elliptic from 6.5.2 to 6.5.3 (#266) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.2...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * bar chart gradient example in docs (#268) Co-authored-by: Isaac Ezer <isaace@spotify.com> * Sankey sorting (#269) * remove deprecated refs definition This old usage of defining refs via a string is deprecated and seems to break when debugging reactochart using `npm link` locally. * add Sankey Sorting Function hooks Co-authored-by: Isaac Ezer <isaace@spotify.com> * 3.2.0 * v3.2.0 release * Fix YAxisLabels formatting example (#271) The current example did not demonstrate label color/weight change, since the final label (`label.text`) never was `20.00`. * 3.2.1 * 3.2.1 release * [A11y] add aria-hidden attributes to XYPlot (#273) * add aria-hidden attributes to XYPlot elements * more granual application of aria-hidden * 3.2.2 * Add changelog edit for 3.2.2 * v3.2.2 release * v3.2.2 release * Upgrade D3 6.3.1 (#276) * d3 6.0 * update imports * make all the things prettier * restrict d3 import * remove global d3 imports from specs Co-authored-by: Isaac Ezer <isaace@spotify.com> * 4.0.0 * v4.0.0 release * remove old node versions. Support >=12 (#287) * remove old node versions. Support >=12 * auto fix audit errors * remove node 16, build failing * update package-lock.json Co-authored-by: Isaac Ezer <isaace@spotify.com> * Bump lodash from 4.17.15 to 4.17.21 (#285) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.21) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump elliptic from 6.5.3 to 6.5.4 (#278) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.3...v6.5.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 5.0.0 * v5.0.0 release * Migrate jsdom tests to jest (#291) * Create dependabot.yml * [Infra] Enable a Github Action for CI (#308) * Create node.js.yml * remove browser test step * CI test * Revert "CI test" This reverts commit b2c894a. * Feature/arackis/make work with d3 v7 (#307) * Install d3, update Jest to transpile d3 * Fix unit tests - negative numbers were using the wrong negative unicode character * Include d3@6 as acceptable * Undo whitespace changes in jest config * fix lockfile * 6.0.0 * v6.0.0 release * Accessible Interface for Line/Area Charts (#294) * A11yInterface in reactochart * npm run make-docs + render A11yInterface docs * fix offset bug + more examples * refactor for simplicity * revert the styling since the outline wasn't a problem * A11yInterface Tests * refactor to use datasetsWithAccessor instead * rename + doc generation * wip: refactor of AriaLabelContainer * fix an example, fix bug with chart * fix my examples & refactor again * update package-lock * 6.1.0 * v6.1.0 release * Bump shelljs from 0.8.4 to 0.8.5 (#343) Bumps [shelljs](https://github.com/shelljs/shelljs) from 0.8.4 to 0.8.5. - [Release notes](https://github.com/shelljs/shelljs/releases) - [Changelog](https://github.com/shelljs/shelljs/blob/master/CHANGELOG.md) - [Commits](shelljs/shelljs@v0.8.4...v0.8.5) --- updated-dependencies: - dependency-name: shelljs dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @babel/cli from 7.10.0 to 7.16.8 (#342) Bumps [@babel/cli](https://github.com/babel/babel/tree/HEAD/packages/babel-cli) from 7.10.0 to 7.16.8. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.16.8/packages/babel-cli) --- updated-dependencies: - dependency-name: "@babel/cli" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Upgrades (#345) * npm update * npm audit fix * fix warning about map without key in examples * wip web-script 5 * web-scripts 6 * wip web-scripts 7 * wip npm audit fix * wip web-scripts 8 * wip web-scripts 9 * wip web-scripts 10 * web-scripts 11 * some more audit fixes * document npm link * Bump url-parse from 1.5.4 to 1.5.10 (#354) Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.4 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](unshiftio/url-parse@1.5.4...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Vulnerability upgrades (#358) * Bump remark + remark-react * bump web-scripts & misc updates * bump webpack to 5.x * clean up CODEOWNERS * Bump @babel/plugin-proposal-object-rest-spread from 7.10.0 to 7.17.3 (#350) Bumps [@babel/plugin-proposal-object-rest-spread](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-proposal-object-rest-spread) from 7.10.0 to 7.17.3. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.17.3/packages/babel-plugin-proposal-object-rest-spread) --- updated-dependencies: - dependency-name: "@babel/plugin-proposal-object-rest-spread" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump postcss from 7.0.35 to 7.0.39 (#352) Bumps [postcss](https://github.com/postcss/postcss) from 7.0.35 to 7.0.39. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/7.0.39/CHANGELOG.md) - [Commits](postcss/postcss@7.0.35...7.0.39) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump follow-redirects from 1.14.7 to 1.14.9 (#353) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.9. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.14.7...v1.14.9) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump d3-color from 3.0.1 to 3.1.0 (#443) Bumps [d3-color](https://github.com/d3/d3-color) from 3.0.1 to 3.1.0. - [Release notes](https://github.com/d3/d3-color/releases) - [Commits](d3/d3-color@v3.0.1...v3.1.0) --- updated-dependencies: - dependency-name: d3-color dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 6.1.1 * v 6.1.1 release Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Anita <acmei@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Isaac Ezer <isaac.ezer@gmail.com> Co-authored-by: Isaac Ezer <isaace@spotify.com> Co-authored-by: Marko Bonaći <mbonaci@users.noreply.github.com> Co-authored-by: Anita Wang <anitaw@spotify.com> Co-authored-by: Markus Wagner <71727154+PRTTMPRPHT@users.noreply.github.com> Co-authored-by: Adam Rackis <arackaf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates reactocharts to work with D3 v7 (but still support 6). There were no changes to the code itself, only to some of the infrastructure to support D3 v7, which now ships as raw esm:
Update Babel to use babel.config.js instead of .babelrc. This was necessary in order to get D3 to transpile in Jest; more info is in this comment: babel-jest does not transpile import/export in node_modules when Babel 7 is used jestjs/jest#6229 (comment)
Running test-browser revealed two failing tests, but these were already failing in master for the same reason. It seems the negative sign that was pasted into the negative numbers in the test (to verify) is not the same character D3 uses for labels. I fixed this, but then ran into other problems with Husky. It seems it runs this by default on commit:
jest --bail --findRelatedTestswhich of course finds my test, and runs it. Unfortunately it fails in Jest for reasons I'm not sure of. That said, this same behavior exists in master, currently, so seems unrelated to this PR. As a result I just skipped the pre-commit hook.