Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades #345

Merged
merged 13 commits into from
Feb 23, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,25 @@ If you'd like to contribute to the development this project, first fork & clone
- `git push` to your forked version of the repo.
- Open a Github pull request with your changes against `master`. 🎉

### NPM Link

If you have an app that depends on reactochart and you want to develop locally, follow the following steps:

1. In the folder for this repo, run `npm build` and then `npm link`
2. In your app folder, run `npm link reactochart`. If you're using webpack, then you also may need the following config:

```json
{
"resolve": {
"symlinks": true,
"alias": {
"react": path.resolve("./node_modules/react"),
"react-dom": path.resolve("./node_modules/react-dom")
}
}
}
```

### Notes

- **Do not make any changes in the `lib` or `examples/build` directories**, as these directories are destroyed and
Expand Down
8 changes: 4 additions & 4 deletions docs/src/docs/BarChart/examples/BarChart.js.example
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ const BarChartExample = (props) => {
const chartDefs = _.zip([numbers, letters, dates], [getNumberValue, getLetterValue, getDateValue]);

return <div>
{([true, false]).map(horizontal => {
return <div>
{([true, false]).map((horizontal, index) => {
return <div key={index}>
<h4>{horizontal ? "Horizontal" : "Vertical"}</h4>

{chartDefs.map(([data, getValue]) => {
return <XYPlot width={320} height={320}>
{chartDefs.map(([data, getValue], index2) => {
return <XYPlot width={320} height={320} key={index2}>
<XAxis /><YAxis />
<BarChart
data={data}
Expand Down
Loading