New features for SankeyDiagram #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 14, 2018 17:27
…ments, to be rendered in the SVG wrapped in foreignObject tag
|
@krissalvador27 These features should now be ready to go - take a look & I'll do a release for ya tomorrow if all looks okay. Let me know if you have any other missing features. Thanks! -d |
krissalvador27
approved these changes
Feb 23, 2018
|
THanks 👍 merging |
install
pushed a commit
that referenced
this pull request
Feb 25, 2020
New features for SankeyDiagram
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple new Sankey Diagram features for Kris, still in progress:
nodeLabelTextprop - should allow passing either a string (which will be wrapped in a "text" element) or an arbitrary node (which will be rendered as-is)