optionally use cert manager for mutating web hook certificates #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds option to the values.yaml so that the install can use cert-manager to generate the web-hook certificate
Fixes the issue of the cert not having the the right SANs. See kubeflow/spark-operator#1224, and consider kubeflow/spark-operator#1178 and other issues.
The standard installation uses a script as as init job to generate the certificate secret. This PR allows
cert-manager to generate the secret instead. In either case, the actual mutating web hook configuration
is generated in code rather than by helm manifest [?], but the secret is mounted into the pod and read
from the filesystem in any case.