Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated API #27

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Updated API #27

merged 3 commits into from
Jun 25, 2024

Conversation

andriidem308
Copy link
Contributor

  • fixed issue with Twisted
  • added new messages

- fixed issue with Twisted
- added new messages
@amusleh-spotware-com
Copy link
Member

Please add new commands of console sample to help text:
Screenshot_2


def executeUserCommand():
try:
print("\n")
userInput = inputimeout("Command (ex help): ", timeout=18)
userInput = inputimeout("Command (ex help): ", timeout=180)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting timeout too high will cause disconnection because it will keep the thread busy and while waiting for user input we can't send heartbeat to server, please set it back to 18 or find a better way to handle this case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@amusleh-spotware-com
Copy link
Member

Please also update poetry version in build backend of pyroject.toml to:

[build-system]
requires = ["poetry-core>=1.0.8"]
build-backend = "poetry.core.masonry.api"

This will allow installing package in editable mode via Pip.

andriidem308 and others added 2 commits June 25, 2024 14:15
@andriidem308
Copy link
Contributor Author

Please also update poetry version in build backend of pyroject.toml to:

[build-system]
requires = ["poetry-core>=1.0.8"]
build-backend = "poetry.core.masonry.api"

This will allow installing package in editable mode via Pip.

Please also update poetry version in build backend of pyroject.toml to:

[build-system]
requires = ["poetry-core>=1.0.8"]
build-backend = "poetry.core.masonry.api"

This will allow installing package in editable mode via Pip.

done

@andriidem308
Copy link
Contributor Author

Please add new commands of console sample to help text: Screenshot_2

done

@amusleh-spotware-com amusleh-spotware-com merged commit 5320d7d into spotware:main Jun 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants