Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device expiry time calculation seems broken in UI #282

Closed
lts-rad opened this issue Feb 7, 2024 · 9 comments
Closed

device expiry time calculation seems broken in UI #282

lts-rad opened this issue Feb 7, 2024 · 9 comments
Assignees

Comments

@lts-rad
Copy link
Contributor

lts-rad commented Feb 7, 2024

No description provided.

@lts-rad lts-rad self-assigned this Feb 7, 2024
@lts-rad
Copy link
Contributor Author

lts-rad commented Feb 8, 2024

@0vercl0k i have not been able to reproduce this yet

@lts-rad
Copy link
Contributor Author

lts-rad commented Feb 8, 2024

need to test closer to 0 GMT in case this is a bug with the timeAgo.js package

@lts-rad
Copy link
Contributor Author

lts-rad commented Feb 8, 2024

smells like hustcc/timeago.js#222

@0vercl0k
Copy link

0vercl0k commented Feb 8, 2024 via email

@lts-rad
Copy link
Contributor Author

lts-rad commented Feb 8, 2024

Expire in ${timeAgo(
    new Date('07 Feb 2024 03:39:31 GMT').toUTCString()
  , 'en_US', {relativeDate: '07 Feb 2024 02:26:31 GMT'})}

correctly reports 1 hour at least

@lts-rad
Copy link
Contributor Author

lts-rad commented Feb 8, 2024

seems like the issue is not with the rendering. perhaps a UI state error with inputting the wrong time

@0vercl0k
Copy link

0vercl0k commented Feb 8, 2024 via email

@lts-po
Copy link
Collaborator

lts-po commented Feb 9, 2024

@0vercl0k think its related to editing a pending device, does it work ok when editing a device that is not pending / after its auth'd? pushing a fix that will handle this for pending devices

lts-po pushed a commit that referenced this issue Feb 9, 2024
lts-po pushed a commit that referenced this issue Feb 9, 2024
@0vercl0k
Copy link

0vercl0k commented Feb 9, 2024 via email

lts-rad added a commit that referenced this issue Feb 22, 2024
ui:
- alerts view fixes
- default icon and color for new devices
- disable edit of pending devices
- catch auth:failure events by default
- remove autoFocus for some input elements
api:
- Add device names as .lan domains
- For local mappings allow multiple names for one I
build:
- base image now uses 23.10 mantic for pi5 support and 6.5 kernel


* [build] move codeql scans to the dev branch

* [wifid] Address #279 by resetting wlan0 down/up on startup

* [ui] fix #271

* gluestack + iOS updates (#280)

* [ui] fix for ios build
* [ui] bump gluestack

---------

Co-authored-by: lts-po <po@longterm.io>

* [ui] qrcode for device component

* [ui] get device, with psk if otp

* [ui] show otp in modal

* [ui] show login info & qrcode for device

* [api] /device route to include psk if otp auth

* [ui] menu order

* [ui] validate ip for iOS

* [ui] send JSONPath query to api

* [ui] skip otp modal for auth page

* [ui] fix width for new gluestack, desktop

* [ui] only set endpoint if default endpoint is set

* [ui] useRNModal for web for menu/popup inside of modal

* [ui] input is wider now

* [ui] use actionsheet if more items

* empty out template device

* [ui] react-native - same as gstack

* [build] [ios] Attempt verion updates

* [ui] bump gluestack

* [ui] ios build

* [ui] remove autoFocus to avoid keyboard popup

* [ui] skip autoFocus

* [ui] skip autoFocus

* [ui] Select component for alert state

* [ui] fix eventTemplate for ios, only build template strings

* [api] Update error codes to 400

* [ui] Move New item to the top of the Item Menu

* [build] Move back from self hosted due to caching annoyances

* [api] Add device names as .lan domains

* [api] For local mappings allow multiple names for one IP

* [ui] auth:failure to catch event

* [ui] auth events

* [ui] change default notificationType to warning/error in sample alerts

* [ui] skip autoFocus

* [ui] use Textarea for body

* [ui] list alerts for mobile

* [ui] set default icon and color

* [ui] no edit of pending devices, #282

* [ui] no edit of pending devices, #282

* [ui] fix alert position on mobile

* [ui] use Select component. Fix #285

* [ui] show items on new line

* [packet_logs] remove old ulogd2 code and docs

* [plugin-lookup] update docs

* [installer] Update installer for 23.10

* [build] Update go packages for moby fixes

* [dyndns] Update golang to 1.21.5

* [build] [dyndns] Fix golang package name

* [build] [clearfog] Update to mantic base image & kernel

* [build] [dyndns] Fix to 3.0.7, don't need webserver backend

---------

Co-authored-by: Alex Radocea <alex@supernetworks.org>
Co-authored-by: lts-po <po@longterm.io>
@lts-rad lts-rad closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants