-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
device expiry time calculation seems broken in UI #282
Comments
@0vercl0k i have not been able to reproduce this yet |
need to test closer to 0 GMT in case this is a bug with the timeAgo.js package |
smells like hustcc/timeago.js#222 |
i'm happy to try to repro again or help in any way :) Give me a shout!
…On Thu, Feb 8, 2024 at 10:50 AM Alex Rad ***@***.***> wrote:
smells like hustcc/timeago.js#222
<hustcc/timeago.js#222>
—
Reply to this email directly, view it on GitHub
<#282 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALIORPFF27JQXHBGO2L4YLYSUM77AVCNFSM6AAAAABC5BM746VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZUG4ZTSOBXGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
correctly reports 1 hour at least |
seems like the issue is not with the rendering. perhaps a UI state error with inputting the wrong time |
I can still repro this on latest flights fwiw
…On Thu, Feb 8, 2024 at 12:04 PM Alex Rad ***@***.***> wrote:
seems like the issue is not with the rendering. perhaps a UI state error
with inputting the wrong time
—
Reply to this email directly, view it on GitHub
<#282 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALIOROJ5MFVOEJMBPIXHBLYSUVTLAVCNFSM6AAAAABC5BM746VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZUHA2TANJZGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@0vercl0k think its related to editing a pending device, does it work ok when editing a device that is not pending / after its auth'd? pushing a fix that will handle this for pending devices |
I've just tried it out - it seems the UI behaves the same way if I connect
a device "Expire in 8 minute ago". But the device actually doesn't seem to
be auto removed so maybe it's just a UI display issue?
…On Fri, Feb 9, 2024 at 4:19 AM lts-po ***@***.***> wrote:
@0vercl0k <https://github.com/0vercl0k> think its related to editing a
pending device, does it work ok when editing a device that is not pending /
after its auth'd? pushing a fix that will handle this for pending devices
—
Reply to this email directly, view it on GitHub
<#282 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALIORJYVTXYMGDZ55DKIULYSYH6FAVCNFSM6AAAAABC5BM746VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZVHAZTANZQGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
ui: - alerts view fixes - default icon and color for new devices - disable edit of pending devices - catch auth:failure events by default - remove autoFocus for some input elements api: - Add device names as .lan domains - For local mappings allow multiple names for one I build: - base image now uses 23.10 mantic for pi5 support and 6.5 kernel * [build] move codeql scans to the dev branch * [wifid] Address #279 by resetting wlan0 down/up on startup * [ui] fix #271 * gluestack + iOS updates (#280) * [ui] fix for ios build * [ui] bump gluestack --------- Co-authored-by: lts-po <po@longterm.io> * [ui] qrcode for device component * [ui] get device, with psk if otp * [ui] show otp in modal * [ui] show login info & qrcode for device * [api] /device route to include psk if otp auth * [ui] menu order * [ui] validate ip for iOS * [ui] send JSONPath query to api * [ui] skip otp modal for auth page * [ui] fix width for new gluestack, desktop * [ui] only set endpoint if default endpoint is set * [ui] useRNModal for web for menu/popup inside of modal * [ui] input is wider now * [ui] use actionsheet if more items * empty out template device * [ui] react-native - same as gstack * [build] [ios] Attempt verion updates * [ui] bump gluestack * [ui] ios build * [ui] remove autoFocus to avoid keyboard popup * [ui] skip autoFocus * [ui] skip autoFocus * [ui] Select component for alert state * [ui] fix eventTemplate for ios, only build template strings * [api] Update error codes to 400 * [ui] Move New item to the top of the Item Menu * [build] Move back from self hosted due to caching annoyances * [api] Add device names as .lan domains * [api] For local mappings allow multiple names for one IP * [ui] auth:failure to catch event * [ui] auth events * [ui] change default notificationType to warning/error in sample alerts * [ui] skip autoFocus * [ui] use Textarea for body * [ui] list alerts for mobile * [ui] set default icon and color * [ui] no edit of pending devices, #282 * [ui] no edit of pending devices, #282 * [ui] fix alert position on mobile * [ui] use Select component. Fix #285 * [ui] show items on new line * [packet_logs] remove old ulogd2 code and docs * [plugin-lookup] update docs * [installer] Update installer for 23.10 * [build] Update go packages for moby fixes * [dyndns] Update golang to 1.21.5 * [build] [dyndns] Fix golang package name * [build] [clearfog] Update to mantic base image & kernel * [build] [dyndns] Fix to 3.0.7, don't need webserver backend --------- Co-authored-by: Alex Radocea <alex@supernetworks.org> Co-authored-by: lts-po <po@longterm.io>
No description provided.
The text was updated successfully, but these errors were encountered: