Throw, don't overflow. Fix #160 #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrudolph
reviewed
Oct 23, 2017
There was a problem hiding this comment.
Good one, that seems quite useful.
I wonder if that wouldn't be stricter than before, though. It seems it would have silently rounded decimal numbers before but now it would reject them. While it seems like acceptable behavior we cannot just make this change without thinking about keeping compatibility with the old behavior. (On the other hand I see allowing overflowing as a bug which would be fixed by this PR)
|
Tempted to merge this as overflows should be considered bugs; I'll omit in today's bump, since we mostly care for 2.13 Scala support now, but this could indeed be a good candidate to merge |
ktoso
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Just hit this issue and added checks for integral value bounds. Thanks.
PS. This is my original work.