Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-1323] Allow filtering Products on PLP by a custom price range #11007

Merged
merged 13 commits into from
May 10, 2021
Merged

[SD-1323] Allow filtering Products on PLP by a custom price range #11007

merged 13 commits into from
May 10, 2021

Conversation

mad-eel
Copy link
Contributor

@mad-eel mad-eel commented May 5, 2021 •
edited
Loading

This PR tries not to change how the base searcher uses params for filtering, but instead prepare data in a current structure.

TODO:

  • add a basic form
  • verify input data
  • use JS ES6 instead of jQuery for handling inputs
  • add mobile view
  • add styles to the form
  • add "More than $300" filter

@mad-eel mad-eel added the WIP label May 5, 2021
@mad-eel mad-eel requested a review from damianlegawiec May 5, 2021 14:20
@mad-eel mad-eel self-assigned this May 5, 2021
@mad-eel mad-eel force-pushed the sd-1323-allow-filtering-products-by-giving-custom-price-range branch from 50130fb to dbd610e Compare May 5, 2021 14:21
@mad-eel mad-eel requested a review from damianlegawiec May 6, 2021 12:22
@mad-eel mad-eel force-pushed the sd-1323-allow-filtering-products-by-giving-custom-price-range branch from 76ffa19 to 23cbef1 Compare May 7, 2021 06:23
@mad-eel mad-eel force-pushed the sd-1323-allow-filtering-products-by-giving-custom-price-range branch from c2f745f to a212b03 Compare May 7, 2021 11:02
@mad-eel mad-eel removed the WIP label May 7, 2021
@mad-eel mad-eel marked this pull request as ready for review May 7, 2021 13:32
@mad-eel mad-eel requested review from MatthewKennedy and Vegann May 7, 2021 13:32
damianlegawiec
damianlegawiec reviewed May 7, 2021
View reviewed changes
frontend/app/helpers/spree/frontend_helper.rb Outdated Show resolved Hide resolved
frontend/app/helpers/spree/frontend_helper.rb Outdated Show resolved Hide resolved
frontend/app/helpers/spree/frontend_helper.rb Outdated Show resolved Hide resolved
frontend/app/models/spree/filters/less_than_price_range.rb Outdated Show resolved Hide resolved
frontend/app/models/spree/filters/price_range.rb Outdated Show resolved Hide resolved
@mad-eel mad-eel requested a review from damianlegawiec May 10, 2021 07:27
damianlegawiec
damianlegawiec approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@damianlegawiec damianlegawiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work! ❤️

@damianlegawiec damianlegawiec added this to the 4.3 milestone May 10, 2021
@damianlegawiec damianlegawiec merged commit 0480c61 into master May 10, 2021
@damianlegawiec damianlegawiec deleted the sd-1323-allow-filtering-products-by-giving-custom-price-range branch June 8, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianlegawiec damianlegawiec damianlegawiec approved these changes

@MatthewKennedy MatthewKennedy Awaiting requested review from MatthewKennedy

@Vegann Vegann Awaiting requested review from Vegann

Assignees

@mad-eel mad-eel

Labels
Storefront 🛒
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@mad-eel @damianlegawiec