This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Exclude Slash from Encode, when calling getURL() #805
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
In the PathResourceResolver.isResourceUnderLocation method, a slash is placed in the locationPath to verify the resource. Therefore, the slash should be excluded when encoding the object name.
PathResourceResolver class : org.springframework.web.servlet.resource.PathResourceResolver
💡 Motivation and Context
I am using S3 to manage static resources.
Using the spring, I wrote the setting code as follows.
-- application.yml
spring.resources.staticLocations:
- 's3://bucketName/admin/beta/'
And I registered the following Beans.
In this environment, when I make a request such as "https://domain.com/index.html", the PathResourceResolver.isResourceUnderLocation method does not find the file correctly due to URL encoding problems.
💚 How did you test it?
Modified the existing test code.
📝 Checklist
🔮 Next steps