Ensure initContainer(s) will configure args provided. #474
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
reviewed
Sep 3, 2024
| @@ -893,7 +893,7 @@ public static class ContainerProperties { | |||
| private String containerName; | |||
|
|
|||
| private List<String> commands; | |||
|
|
|||
| private List<String> args; | |||
onobc
reviewed
Sep 3, 2024
| @@ -925,6 +925,14 @@ public void setCommands(List<String> commands) { | |||
| this.commands = commands; | |||
| } | |||
|
|
|||
| public List<String> getArgs() { | |||
There was a problem hiding this comment.
It seems like before this change we were using commands to contain both command + args. If users were previously doing commands = "sh,-c,script2.sh" will they now have to use commands = "sh" + args = "-c,script2.h" or will both variants still be supported? IOW - will this break existing configurations?
There was a problem hiding this comment.
This test was just to validate the provision of args are applied as expected.
commands overrides the entrypoint.
args is added to the entrypoint.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #473