-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calculated forwarded prefix using path and original uri #377
Conversation
I've never heard of x original uri, can you point me to some resources? |
Codecov Report
@@ Coverage Diff @@
## master #377 +/- ##
==========================================
+ Coverage 65.36% 68.44% +3.07%
==========================================
Files 4 124 +120
Lines 231 3473 +3242
Branches 17 237 +220
==========================================
+ Hits 151 2377 +2226
- Misses 68 966 +898
- Partials 12 130 +118
Continue to review full report at Codecov.
|
Seems from a bit of searching to be an nginx thing, which makes sense as I'm running behind an Ingress. I guess this means this solution is not generic and I should close the PR. |
@spencergibb Would RouteToRequestUrlFilter be a better place to check for and add the prefix header (if an appropriate property is set)? |
I don't think so. |
Or maybe it can be done in XForwardedHeadersFilter by getting the Route object from exchange.getAttribute(GATEWAY_ROUTE_ATTR) |
That seems like a better way. |
for #314