ConditionalOnMissingBean on formBodyWrapperFilter, debugFilter and servlet3... #3609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencergibb
requested changes
Jul 29, 2019
…0WrapperFilter conditional on missing bean
rzukow
force-pushed
the
conditional-pre-filters
branch
from
fec6a17 to
7b04f68
Compare
Codecov Report
@@ Coverage Diff @@
## master #3609 +/- ##
===========================================
+ Coverage 62.16% 65% +2.83%
- Complexity 667 1504 +837
===========================================
Files 98 190 +92
Lines 3124 7272 +4148
Branches 342 870 +528
===========================================
+ Hits 1942 4727 +2785
- Misses 1060 2235 +1175
- Partials 122 310 +188
Continue to review full report at Codecov.
|
Done. |
rzukow
changed the title
sabareeshkkanan
added a commit
to sabareeshkkanan/spring-cloud-netflix
that referenced
this pull request
Dec 20, 2019
* Added symbolic link of index.adoc * Added symbolic link of index.adoc * set replication client filters in RefreshablePeerEurekaNodes (spring-cloud#3610) fixes spring-cloudgh-3554 * Update SNAPSHOT to 2.2.0.M2 * Going back to snapshots * Adding spring cloud circuitbreaker hystrix implementation * Separated circuitbreaker auto config to its own file * Initialize remoteRegionAppWhitelist with default value (spring-cloud#3634) * Moves non-netflix dependencies out of bom into root pom. fixes spring-cloudgh-3639 * Removes dependency management for okhttp3 * Moves okhttp3 dep mgmt back to bom * Re-create connection manager on "zuul.host.*" property change (spring-cloud#3407) * Re-create connection manager on "zuul.host.*" property change Fixes spring-cloud#3406 * Wrap connectionManager.shutdown() in try/catch block. Polishing * Removes okhttp3 again after added back in older branch. * Updating readme with note about building spring-cloud-netflix-hystrix-contract. Fixes spring-cloud#3497 * Fromatting * Upgrades eureka to 1.9.13 and excludes compactmap. fixes spring-cloudgh-3636 * Update SNAPSHOT to 2.1.3.RELEASE * Going back to snapshots * Bumping versions to 2.1.4.BUILD-SNAPSHOT after release * Add Spring Cloud LoadBalancer starter to Eureka starters. Fixes spring-cloudgh-3646. (spring-cloud#3647) * Update docs. (spring-cloud#3650) * ConditionalOnMissingBean on formBodyWrapperFilter, debugFilter… (spring-cloud#3609) * Bumping versions * Remove spring.provides. * removes useless comments * Fix RestTemplateEurekaHttpClient status update endpoint. Fixes spring-cloud#3571 (spring-cloud#3657) * polish * Updates health check handler to use new StatusAggregator * Gh 3409 turbine stream test (spring-cloud#3665) * Add stream-test-support. * Fix condition. * Remove outdated workaround. * Bumping versions * Optimize code of eureka (spring-cloud#3660) * Optimize code of eureka * Merge newest code * fix checkstyle bug * Gh 3464 upgrade scc new (spring-cloud#3667) * Upgrade Spring Cloud Contract version to 2.1.3.RELEASE. * Gh 3409 turbine stream test (spring-cloud#3665) * Add stream-test-support. * Fix condition. * Remove outdated workaround. (cherry picked from commit 24f5e0b) * Updates to use "components" rather than "details" See spring-projects/spring-boot#17929 * Applying spring-cloud#3407 to the 2.1.x branch * Added support for reactive service discovery * Update SNAPSHOT to 2.2.0.M3 * Going back to snapshots * Update SNAPSHOT to 2.2.0.RC1 * Going back to snapshots * removing resource class from circle config * Add property to disable spring cloud circuit breaker for hystrix * Fix command key configuration. Use id as command key and class as group key. * Adding configuration metadata for spring cloud circuitbreaker * Bumping versions * Fix some dependencies that show up in the wrong scope Apparently you can build on the command line but Eclipse is fussy now and wouldn't compile these projects without explicit dependencies. * Also add build helper config for contract tests * Added maven flatten plugin * Bumping versions * Update SNAPSHOT to 2.2.0.RC2 * Going back to snapshots * Update configuration to use proxyBeanMethods=false. Fixes spring-cloud#3677 * Create security.md * Update issue templates * Bumping versions * Bumping versions * Update SNAPSHOT to 2.2.0.RELEASE * Going back to snapshots * Bumping versions to 2.2.1.BUILD-SNAPSHOT after release * Bumping versions * Fix typo: clas -> class (spring-cloud#3710) * removes .flattened-pom.xml * ignores .flattened-pom.xml * Gh 3718 add zoned loadbalancer instrumentation (spring-cloud#3720) * Add instrumentation for zoned LoadBalancer. * Add documentation. * Fix after review. * Fix after review. * Update SNAPSHOT to 2.2.1.RELEASE * Going back to snapshots * Bumping versions to 2.2.2.BUILD-SNAPSHOT after release Co-authored-by: Marcin Grzejszczak <marcin@grzejszczak.pl> Co-authored-by: Yuxin Bai <LittleBaiBai@users.noreply.github.com> Co-authored-by: Spencer Gibb <spencer@gibb.tech> Co-authored-by: Spring Buildmaster <buildmaster@springframework.org> Co-authored-by: Ryan Baxter <rbaxter@pivotal.io> Co-authored-by: emilnkrastev <emilnkrastev@gmail.com> Co-authored-by: Denys Ivano <denys.ivano@gmail.com> Co-authored-by: Olga Maciaszek-Sharma <olga.maciaszek@gmail.com> Co-authored-by: Rafał Żukowski <rzukow@gmail.com> Co-authored-by: OLPMO <OLPMO@users.noreply.github.com> Co-authored-by: Tim Ysewyn <Tim.Ysewyn@me.com> Co-authored-by: Dave Syer <david_syer@hotmail.com> Co-authored-by: Deepika Mohan <deepikadevidm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do you think about adding some ConditionalOnMissingBean annotation to pre filters?
The problem we are facing is DebugFilter that is calling request.getParameter(DEBUG_PARAMETER.get()) just to check the value of debug and ignore it, and there is no easy way to disable it.
I added some other beans as described here: https://www.anaplan.com/blog/using-zuul-in-production/ , but the article is outdated anyway.