Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align project name with the tutorial (https://spring.io/guides/gs/messaging-rabbitmq/) #34

Closed
wants to merge 1 commit into from

Conversation

naXa777
Copy link
Contributor

@naXa777 naXa777 commented Dec 13, 2021

goal: the following commands given in the tutorial should work "as is"

  • java -jar build/libs/gs-messaging-rabbitmq-0.1.0.jar
  • java -jar target/gs-messaging-rabbitmq-0.1.0.jar

without this change the above commands generate an error like:

Error: Unable to access jarfile build/libs/gs-messaging-rabbitmq-0.1.0.jar

…saging-rabbitmq/)

goal: the following commands given in the tutorial work "as is"
- `java -jar build/libs/gs-messaging-rabbitmq-0.1.0.jar`
- `java -jar target/gs-messaging-rabbitmq-0.1.0.jar`
@naXa777
Copy link
Contributor Author

naXa777 commented Feb 3, 2022

@artembilan @dsyer please review

@artembilan
Copy link

This one requires a team discussion since all of the guides suffer same problem.
Those tutorials are based on this template: https://raw.githubusercontent.com/spring-guides/getting-started-macros/main/build_an_executable_jar_with_both.adoc.

Therefore the name for the artifact is really not what is chosen in the build config, but just top project id, like this one is gs-messaging-rabbitmq.

@naXa777
Copy link
Contributor Author

naXa777 commented Nov 21, 2022

@artembilan @dsyer did you have a chance to discuss the problem?

@robertmcnees
Copy link
Contributor

Hi @naXa777. The underlying issue for this PR should be fixed with a recent PR #43. Specifically, this PR adds an additional variable so that the project_id and build_name can be different.

The build section now uses a different common file for instructions. If you get around to it, give the guide a try with the updated instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants