Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package cleaner should replace hyphens with underscores #1339

Closed
chrylis opened this issue Oct 27, 2022 · 1 comment
Closed

Package cleaner should replace hyphens with underscores #1339

chrylis opened this issue Oct 27, 2022 · 1 comment

Comments

@chrylis
Copy link

chrylis commented Oct 27, 2022

When the package name for a project contains hyphens, these are squashed (as hyphens are not legal characters), but it would be a bit clearer if they were replaced with underscores instead of the current removal, which is the official naming recommendation

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 27, 2022
@rosennej
Copy link

The same applied for package names generated automatically. Our web address is qsm-fss.com, so according to the rules we use com.qsm-fss in the Maven group, and expect com.qsm_fss in the generated package name. But the generated MD says: "* The original package name 'com.qsm-fss.sb-demo.demo' is invalid and this project uses 'com.qsmfss.sbdemo.demo' instead."

@mhalbritter mhalbritter added type: enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 31, 2024
@mhalbritter mhalbritter added this to the 0.21.0 milestone May 22, 2024
mhalbritter added a commit to spring-io/start.spring.io that referenced this issue May 23, 2024
odrotbohm pushed a commit to odrotbohm/start.spring.io that referenced this issue May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants