Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Maven extensions #1290

Closed
wants to merge 1 commit into from
Closed

Conversation

herder
Copy link
Contributor

@herder herder commented Dec 27, 2021

This adds support for adding extension entries to the Maven pom. This is useful to be able to use plugins that are dependant on OS version, for example, by extending with the os-maven plugin.

This adds support for adding extension entries to the Maven pom. This is useful to be able to use plugins that are dependant on OS version, for example, by extending with the os-maven plugin.
@wilkinsona
Copy link
Contributor

Thanks for the PR, @herder. I just wanted to acknowledge that we'd seen it. We have a number of higher priority things to be working on at the moment so, unfortunately, it may take a while before we get a change to look at this in detail. Thanks for bearing with us.

@herder
Copy link
Contributor Author

herder commented Feb 10, 2022

No worries - thanks for the update!

@herder
Copy link
Contributor Author

herder commented Jan 20, 2023

Friendly ping - would it be possible to take a look at this? I hope it's a fairly non-problematic feature, and I'd love to stop needing to maintain my own fork for this.

If not, I totally understand - I know you have a lot on your plate in the team! :)

@snicoll snicoll self-assigned this Jun 12, 2023
@snicoll snicoll added type: enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 12, 2023
@snicoll snicoll added this to the 0.20.0 milestone Jun 12, 2023
snicoll pushed a commit that referenced this pull request Jun 12, 2023
This commit adds support for adding extension entries to the Maven pom.

This is useful to be able to use plugins that are dependent on OS
version, for example, by extending with the os-maven plugin.

See gh-1290
snicoll added a commit that referenced this pull request Jun 12, 2023
@snicoll snicoll closed this in d48f763 Jun 12, 2023
@snicoll
Copy link
Contributor

snicoll commented Jun 12, 2023

@herder thank you for making your first contribution to Spring Initializr.

@herder herder deleted the add_extensions branch July 22, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants