Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch controllers to use @RestController #1401

Closed
wants to merge 1 commit into from
Closed

Switch controllers to use @RestController #1401

wants to merge 1 commit into from

Conversation

rijusougata13
Copy link
Contributor

@rijusougata13 rijusougata13 commented Apr 4, 2023 •
edited
Loading

This PR fixes #1354 issue.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 4, 2023
@rijusougata13
Copy link
Contributor Author

Hi, @wilkinsona and @mbhave pelase review this.

@snicoll snicoll mentioned this pull request Apr 4, 2023
Closed
@snicoll snicoll changed the title Remove @Controller annotation and add @RestController annotation Switch controllers to use @RestController Apr 4, 2023
@snicoll snicoll added type: enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 4, 2023
@snicoll snicoll added this to the 0.20.0 milestone Apr 4, 2023
@snicoll snicoll self-assigned this Apr 6, 2023
snicoll pushed a commit that referenced this pull request Apr 6, 2023
@rijusougata13 @snicoll
Replace @controller with @RestController
1dd4ddf 
See gh-1401
snicoll added a commit that referenced this pull request Apr 6, 2023
@snicoll
Polish "Replace @controller with @RestController"
7ed74b2 
See gh-1401
@snicoll snicoll closed this in 0de726e Apr 6, 2023
@snicoll
Copy link
Contributor

snicoll commented Apr 6, 2023

@rijusougata13 thank you for making your first contribution to Spring Initializr.

I've reverted the change to SpringCliDistributionController as it can't be a rest controller. Tests were failing to showcase that as well.

@dsyer dsyer mentioned this pull request Aug 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: enhancement
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

Change @Controller to @RestController
3 participants
@rijusougata13 @snicoll @spring-projects-issues