Web endpoints should only accept GET or POST or both as appropriate #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the endpoints in initializr use @RequestMapping with no explicit RequestMethod, probably for historical reasons (@GetMapping and friends didn't exist when we started this project). It would be more expressive to show which methods are expected to be used, and I doubt anyone actually relies on being able to PATCH, PUT or POST these endpoints. They might get a surprise if they tried to DELETE as well.
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
changed the title
snicoll
added
type: bug
and removed
status: waiting-for-triage
snicoll
changed the title
snicoll
pushed a commit
that referenced
this pull request
Sep 8, 2023
All the endpoints in initializr use @RequestMapping with no explicit RequestMethod, probably for historical reasons (@GetMapping and friends didn't exist when we started this project). It would be more expressive to show which methods are expected to be used, and I doubt anyone actually relies on being able to PATCH, PUT or POST these endpoints. They might get a surprise if they tried to DELETE as well. See gh-1456
snicoll
added a commit
that referenced
this pull request
Sep 8, 2023
|
Thanks Dave |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the endpoints in initializr use
@RequestMappingwith no explicitRequestMethod, probably for historical reasons (@GetMappingand friends didn't exist when we started this project). It would be more expressive to show which methods are expected to be used, and I doubt anyone actually relies on being able to PATCH, PUT or POST these endpoints. They might get a surprise if they tried to DELETE as well.Fixes #1453