Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip file name should match artifact id #1492

Closed
wants to merge 1 commit into from

Conversation

ymougenel
Copy link
Contributor

@ymougenel ymougenel commented Dec 14, 2023

Hello,
After I came accross the same issue described here (zip name does not match artifactId), I thought I could give it a try and fix it:

Reproducing

http://localhost:8080/starter.zip?artifactId=hello world!

Before

  • ArtifactId: hello-world
  • zip name: hello_world!.zip

After

  • ArtifactId: hello-world
  • zip name: hello-world.zip

Please let me know if I have forgotten anything

@pivotal-cla
Copy link

@ymougenel Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 14, 2023
@pivotal-cla
Copy link

@ymougenel Thank you for signing the Contributor License Agreement!

@mhalbritter mhalbritter changed the title fix: zip name matches artifactId Zip file name doesn't match artifact id Jan 31, 2024
@mhalbritter mhalbritter added type: bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 31, 2024
mhalbritter pushed a commit that referenced this pull request Jan 31, 2024
@mhalbritter
Copy link
Contributor

Thanks a lot!

@mhalbritter mhalbritter added this to the 0.21.0 milestone Jan 31, 2024
@mhalbritter mhalbritter changed the title Zip file name doesn't match artifact id Zip file name should match artifact id Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants