Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone repository is added unnecessarily when using a snapshot of a maintenance release #1521

Closed
wants to merge 3 commits into from

Conversation

inanemed
Copy link
Contributor

@inanemed inanemed commented Apr 14, 2024

Closes #1519

@pivotal-cla
Copy link

@inanemed Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@inanemed Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 14, 2024
@inanemed inanemed changed the title Closes #1519 .Fix unnecessary inclusion of milestone repository in maintenance release snapshots. Fix unnecessary inclusion of milestone repository in maintenance release snapshots. Closes #1519 Apr 14, 2024
@inanemed inanemed marked this pull request as ready for review April 14, 2024 11:13
@mhalbritter
Copy link
Contributor

mhalbritter commented Apr 15, 2024

Hey, thanks for the PR, but I don't think this fixes the problem.

3.3.0-SNAPSHOT could still depend on a milestone dependency (which is in the milestone repository). This PR would break that.

What Andy meant in #1519 is that maintenance releases (x.y.z-SNAPSHOT where z > 0) don't need the milestone repos.

@mhalbritter mhalbritter added the status: waiting-for-feedback We need additional information before we can continue label Apr 15, 2024
@inanemed
Copy link
Contributor Author

inanemed commented Apr 15, 2024

Hey,thanks for the clarification.I appreciate it!

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Apr 15, 2024
@mhalbritter mhalbritter changed the title Fix unnecessary inclusion of milestone repository in maintenance release snapshots. Closes #1519 Milestone repository is added unnecessarily when using a snapshot of a maintenance release Apr 16, 2024
@mhalbritter mhalbritter added type: bug and removed status: feedback-provided Feedback has been provided status: waiting-for-triage An issue we've not yet triaged labels Apr 16, 2024
@mhalbritter mhalbritter self-assigned this Apr 16, 2024
@mhalbritter
Copy link
Contributor

Thank you very much and congratulations on your first contribution 🎉!

@mhalbritter mhalbritter added this to the 0.21.0 milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Milestone repository is added unnecessarily when using a snapshot of a maintenance release
4 participants