Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade DGS to 10.0.0 and DGS codegen to 7.0.3 #1684

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

paulbakker
Copy link

Update DGS to 10.0.0 and DGS Codegen to 7.03.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 18, 2024
@mhalbritter mhalbritter self-assigned this Dec 19, 2024
@mhalbritter mhalbritter added type: entry-upgrade and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 19, 2024
@mhalbritter
Copy link
Contributor

mhalbritter commented Dec 19, 2024

Hey @paulbakker,

if I try this on my local machine, the generated project (it uses Kotlin) doesn't build. Instead I get this:

> Task :compileKotlin FAILED
e: file:///home/mhalbritter/.gradle/caches/modules-2/files-2.1/com.netflix.graphql.dgs/graphql-dgs-client/10.0.0/d42cd15448d3e6fc6c55cfb70233a41fa3539905/graphql-dgs-client-10.0.0.jar!/META-INF/graphql-dgs-client.kotlin_moduleModule was compiled with an incompatible version of Kotlin. The binary version of its metadata is 2.1.0, expected version is 1.9.0.
e: file:///home/mhalbritter/.gradle/caches/modules-2/files-2.1/com.netflix.graphql.dgs/graphql-dgs-reactive/10.0.0/1e9f88684099844e6e60fd2c6e6cca7ee1d22aa9/graphql-dgs-reactive-10.0.0.jar!/META-INF/graphql-dgs-reactive.kotlin_moduleModule was compiled with an incompatible version of Kotlin. The binary version of its metadata is 2.1.0, expected version is 1.9.0.
e: file:///home/mhalbritter/.gradle/caches/modules-2/files-2.1/com.netflix.graphql.dgs/graphql-dgs-spring-graphql/10.0.0/ac49dfe42b82f1d63b362e6a8e028429238f18d5/graphql-dgs-spring-graphql-10.0.0.jar!/META-INF/graphql-dgs-spring-graphql.kotlin_moduleModule was compiled with an incompatible version of Kotlin. The binary version of its metadata is 2.1.0, expected version is 1.9.0.
e: file:///home/mhalbritter/.gradle/caches/modules-2/files-2.1/com.netflix.graphql.dgs/graphql-dgs-subscription-types/10.0.0/c4067a67f679fe136a2505bb740a6e3cdf1beb3d/graphql-dgs-subscription-types-10.0.0.jar!/META-INF/graphql-dgs-subscription-types.kotlin_moduleModule was compiled with an incompatible version of Kotlin. The binary version of its metadata is 2.1.0, expected version is 1.9.0.
e: file:///home/mhalbritter/.gradle/caches/modules-2/files-2.1/com.netflix.graphql.dgs/graphql-dgs/10.0.0/b68793ff658aaade77d24287ee57d823bac2ecb7/graphql-dgs-10.0.0.jar!/META-INF/graphql-dgs.kotlin_moduleModule was compiled with an incompatible version of Kotlin. The binary version of its metadata is 2.1.0, expected version is 1.9.0.
[Incubating] Problems report is available at: file:///home/mhalbritter/Downloads/demo/build/reports/problems/problems-report.html

It seems DGS 10.0.0 has been compiled against Kotlin 2.1, while Spring Boot uses Kotlin 1.9.0. Until we have a fix for that, I can't merge the PR.

@paulbakker
Copy link
Author

Thanks for catching that @mhalbritter.
I downgraded the framework back to Kotlin 1.9 and re-released as 10.0.1.
The PR is updated to reflect this.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants