Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/pet-type-specialty-no-id-temp #124

Merged

Conversation

dnokov
Copy link
Contributor

@dnokov dnokov commented Nov 22, 2023

Adding logic for extracting specialties and pet types by id


related to: pull request #123 Detailed information contained there
These changes aim to fix issues #122 #103 while maintaining API first approach.

This part contains only the logic for extracting pet types/specialties
@arey

adding to respective repository interfaces and to service interface/implementation layer
Adding JPA implementation for findPetTypeByName and findSpecialtiesByName
Adding JDBC implementation for findPetTypeByName and findSpecialtiesByName along with respective unit tests
@arey arey added the bug label Nov 23, 2023
@arey
Copy link
Member

arey commented Nov 26, 2023

Thanks @dnokov for your contribution.
I will merge this PR and the 2 related issues then create a refactoring issue.

@arey arey merged commit 65015cb into spring-petclinic:master Nov 26, 2023
1 check passed
@dnokov dnokov deleted the bugfix/petType-specialty-no-id-temp branch December 2, 2023 13:45
@dnokov dnokov restored the bugfix/petType-specialty-no-id-temp branch December 2, 2023 13:45
@dnokov dnokov deleted the bugfix/petType-specialty-no-id-temp branch December 2, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants