Resolve Sonar Issue

spring-projects · Jan 13, 2021 · 0fcb772 · 0fcb772
1 parent 2c929ff
commit 0fcb772
Showing 1 changed file with 15 additions and 11 deletions.
diff --git a/...rc/main/java/org/springframework/amqp/rabbit/listener/DirectMessageListenerContainer.java b/...rc/main/java/org/springframework/amqp/rabbit/listener/DirectMessageListenerContainer.java
@@ -340,17 +340,21 @@ private void adjustConsumers(int newCount) {
 					}
 					doConsumeFromQueue(queue, index);
 				}
-				List<SimpleConsumer> consumerList = this.consumersByQueue.get(queue);
-				if (consumerList != null && consumerList.size() > newCount) {
-					int delta = consumerList.size() - newCount;
-					for (int i = 0; i < delta; i++) {
-						int index = findIdleConsumer();
-						if (index >= 0) {
-							SimpleConsumer consumer = consumerList.remove(index);
-							if (consumer != null) {
-								cancelConsumer(consumer);
-							}
-						}
+				reduceConsumersIfIdle(newCount, queue);
+			}
+		}
+	}
+
+	private void reduceConsumersIfIdle(int newCount, String queue) {
+		List<SimpleConsumer> consumerList = this.consumersByQueue.get(queue);
+		if (consumerList != null && consumerList.size() > newCount) {
+			int delta = consumerList.size() - newCount;
+			for (int i = 0; i < delta; i++) {
+				int index = findIdleConsumer();
+				if (index >= 0) {
+					SimpleConsumer consumer = consumerList.remove(index);
+					if (consumer != null) {
+						cancelConsumer(consumer);
 					}
 				}
 			}