Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DirectMessageListenerContainer Does Not Consider Authentication Failures as Fatal #1347

Closed
garyrussell opened this issue Jun 7, 2021 · 0 comments · Fixed by #1349
Closed

DirectMessageListenerContainer Does Not Consider Authentication Failures as Fatal #1347

garyrussell opened this issue Jun 7, 2021 · 0 comments · Fixed by #1349
Labels
backport:2.2.x (obsolete) type: bug
Milestone
2.3.8

Comments

@garyrussell
Copy link
Contributor

possibleAuthenticationFailureFatal is only used by the SMLC; docs say it applies to both.

We might need to change it to false by default for the DMLC to avoid a behavior change.
@garyrussell garyrussell added this to the 2.3.8 milestone Jun 7, 2021
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jun 8, 2021
@garyrussell
spring-projectsGH-1347: DMLC Ignored Authentication Failures
0b346dc 
Resolves spring-projects#1347

Container starts and keeps trying to connect instead of honoring
the property.
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jun 8, 2021
@garyrussell
spring-projectsGH-1347: DMLC Ignored Authentication Failures
12fb5b9 
Resolves spring-projects#1347

Container starts and keeps trying to connect instead of honoring
the property.

**cherry-pick to 2.2.x**
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jun 8, 2021
@garyrussell
spring-projectsGH-1347: DMLC Ignored Authentication Failures
ebd2709 
Resolves spring-projects#1347

Container starts and keeps trying to connect instead of honoring
the property.

**cherry-pick to 2.2.x**
@garyrussell garyrussell mentioned this issue Jun 8, 2021
Merged
artembilan pushed a commit that referenced this issue Jun 9, 2021
@garyrussell @artembilan
GH-1347: DMLC Ignored Authentication Failures
ea97b11 
Resolves #1347

Container starts and keeps trying to connect instead of honoring
the property.

**cherry-pick to 2.2.x**
artembilan pushed a commit that referenced this issue Jun 9, 2021
@garyrussell @artembilan
GH-1347: DMLC Ignored Authentication Failures
e481891 
Resolves #1347

Container starts and keeps trying to connect instead of honoring
the property.

**cherry-pick to 2.2.x**

# Conflicts:
#	spring-rabbit/src/test/java/org/springframework/amqp/rabbit/listener/DirectMessageListenerContainerIntegrationTests.java
#	src/reference/asciidoc/amqp.adoc
garyrussell added a commit that referenced this issue Jun 10, 2021
@garyrussell
GH-1347: Fix new Sonar issues
29c6673
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backport:2.2.x (obsolete) type: bug
Projects
None yet
Milestone
2.3.8
Development

Successfully merging a pull request may close this issue.

GH-1347: DMLC Ignored Authentication Failures garyrussell/spring-amqp
1 participant
@garyrussell