remove spring-web

[matejsp]

Remove"org.springframework:spring-web" as a dependency.
Why is there even a need for spring-web being used as depedency?
I have excluded it and only one test fails. Perhaps it should have test scope?

[artembilan]

The spring-web is a foundation for the com.rabbitmq:http-client, which is used from the RabbitManagementTemplate.

Not sure what is the problem though. If you don't need it, just exclude.

[artembilan]

@garyrussell ,

I think we need to reconsider these dependencies to be really optional.
The RabbitMQ Hop now provides a ReactiveClient based on the Spring WebFlux: https://github.com/rabbitmq/hop/blob/master/src/main/java/com/rabbitmq/http/client/ReactiveClient.java

Therefore we have to consider to implement a ReactiveRabbitManagementTemplate as well and let end-user to select a desired Web dependency for their purposes.

More over I think this causes an issue with Spring Boot 2.0, where its Web faceset is based on the classpath. So, our explicit spring-web may be as a big culprit there do not let to deal with WebFlux in Spring Boot app.

WDYT?

[garyrussell]

Agreed.

[artembilan]

According the latest changes in the RabbitMQ Hop the Spring Web is optional already: rabbitmq/hop#124.

We need to go ahead and remove (move to test scope) such a dependency from Spring Rabbit.

[artembilan]

The Reactive story is here: https://jira.spring.io/browse/AMQP-812.